Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes those 3 bugs in
seenDevIDslogic inparseFieldsOnMountinfo()which are introduced #1931. fixes #2005.seenDevIDsand overwrote on every occurrence, causing wrong Device values. Now stores the device path and only on first occurrence.rootDir != "/"as the primary signal, which correctly identifies subdirectory mounts.(rootDir == "/")is correctly left as non-bind even if the device was seen before.strings.HasPrefix(mntSrc, "/")guard so virtual filesystems like nsfs (where rootDir is an identifier likenet:[12345], not a path) aren't falsely marked as bind mounts.