feat: adding better flavor tests #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
commented
May 24, 2024
erickzanardo
commented
- Better way to add flavors "on spot" to get better tests
- Adding flavor tests to iOS
erickzanardo
commented
May 24, 2024
eseidel
reviewed
May 27, 2024
eseidel
approved these changes
May 27, 2024
|
Looks like tests are mad at you? Code looks OK though. |
Author
Yeah, these tests started to break after the last Flutter version. But we have been ignoring then for a while since they are not related to what we have been changing. But we should eventually spend some time to get those green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.