fix: add Shorebird storage url as trusted source #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
approved these changes
Aug 30, 2024
eseidel
left a comment
eseidel
left a comment
There was a problem hiding this comment.
I suspect it's better to just make download.shorebird.dev the default (instead of download.flutter.dev) for our flutter fork. That will also make the flutter e2e tests pass.
felangel
added a commit
that referenced
this pull request
Sep 4, 2024
felangel
added a commit
that referenced
this pull request
Sep 12, 2024
felangel
added a commit
that referenced
this pull request
Oct 28, 2024
bryanoltman
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the warning when using Shorebird's storage url