Skip to content

Conversation

@bryanoltman
Copy link

@bryanoltman bryanoltman commented Oct 8, 2025

Support the changes made in shorebirdtech/updater#297

Accessing next_boot_patch no longer performs validation that the patch is bootable, so we need to call shorebird_validate_next_boot_patch before attempting to boot.

@felangel
Copy link

felangel commented Oct 8, 2025

I don't think I have the full context here. I see that we've decoupled getting the next boot patch from validating it but it's not clear to me whether this is solving the 2 validation calls per boot issue and if so how?

@eseidel
Copy link

eseidel commented Oct 8, 2025

You can push with --no-verify to bypass the checks.

@bryanoltman
Copy link
Author

@felangel More context:

Any time the next_boot_patch was accessed, whether for its number, path, or anything else, some basic integrity checks were performed. When booting, this happens through shorebird_next_boot_patch_path. After booting, the updater's patch check logic will ask for the next_boot_patch when determining whether to install the latest available patch (see should_install_patch in updater.rs).

These checks are run more frequently when using package:shorebird_code_push. checkForUpdate calls should_install_patch (which calls next_boot_patch) and then readNextPatch, which also calls next_boot_patch.

@bryanoltman
Copy link
Author

bryanoltman commented Oct 8, 2025

You can push with --no-verify to bypass the checks.

Thanks! Done.

@bryanoltman bryanoltman marked this pull request as ready for review October 8, 2025 21:57
@bryanoltman bryanoltman requested a review from felangel October 8, 2025 21:57
@bryanoltman bryanoltman merged commit f73dc99 into shorebird/dev Oct 8, 2025
3 of 7 checks passed
@bryanoltman bryanoltman deleted the bo/validate-next-boot-patch branch October 8, 2025 22:07
bryanoltman added a commit that referenced this pull request Oct 9, 2025
* fix: validate next boot patch before attempting to boot

* fix dart formatting

* undo formatting changes

* bump updater rev
bryanoltman added a commit that referenced this pull request Oct 14, 2025
* fix: validate next boot patch before attempting to boot

* fix dart formatting

* undo formatting changes

* bump updater rev
felangel pushed a commit that referenced this pull request Oct 27, 2025
* fix: validate next boot patch before attempting to boot

* fix dart formatting

* undo formatting changes

* bump updater rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants