-
Notifications
You must be signed in to change notification settings - Fork 16
fix: validate next boot patch before attempting to boot #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engine/src/flutter/lib/web_ui/lib/src/engine/pointer_binding.dart
Outdated
Show resolved
Hide resolved
|
I don't think I have the full context here. I see that we've decoupled getting the next boot patch from validating it but it's not clear to me whether this is solving the 2 validation calls per boot issue and if so how? |
|
You can push with --no-verify to bypass the checks. |
|
@felangel More context: Any time the These checks are run more frequently when using |
Thanks! Done. |
* fix: validate next boot patch before attempting to boot * fix dart formatting * undo formatting changes * bump updater rev
* fix: validate next boot patch before attempting to boot * fix dart formatting * undo formatting changes * bump updater rev
* fix: validate next boot patch before attempting to boot * fix dart formatting * undo formatting changes * bump updater rev
Support the changes made in shorebirdtech/updater#297
Accessing
next_boot_patchno longer performs validation that the patch is bootable, so we need to callshorebird_validate_next_boot_patchbefore attempting to boot.