Skip to content

ShouldBeGreaterThanOrEqualTo#13

Merged
1 commit merged intomasterfrom
unknown repository
Oct 12, 2010
Merged

ShouldBeGreaterThanOrEqualTo#13
1 commit merged intomasterfrom
unknown repository

Conversation

@mps
Copy link
Copy Markdown
Contributor

@mps mps commented Oct 5, 2010

Added this method which exists in the NUnit core as well.

@xerxesb
Copy link
Copy Markdown
Contributor

xerxesb commented Oct 5, 2010

Hi Matt,

I'm undecided whether I want to put this change through for two reasons:

  1. I don't want to pollute intellisense with more ShouldBe extensions if they're not necessary. Perhaps there is another alternative syntax which is just as palatable and extends across many other scenarios, too
  2. If we did add ShouldBeGreaterThanOrEqualTo, we should add a ShouldBeLessThanOrEqualTo at the same time to keep parity, so this particular commit doesn't have everything we'd need

Anyone else have an opinion on the matter?

@mps
Copy link
Copy Markdown
Contributor Author

mps commented Oct 5, 2010

Since we're improving upon the syntax of basic assertions and the assertion is in the framework we are extending I think it is a valid addition.

@PandaWood
Copy link
Copy Markdown
Contributor

Yes, I'm still thinking about the pollution.
Actually, at this stage, I'm inclined to be more liberal & start trimming later (I must admit, the project I'm using needed a GreaterThan - but not a LessThan).
I felt a bit sorry for the pull request and I'd already added some tests to it so I pulled it in.
I think we'll carry the pollution conversation forward and keep thinking about this.

@xerxesb
Copy link
Copy Markdown
Contributor

xerxesb commented Oct 12, 2010

Yep - need to be conscious of any Should methods added - removing them later is a breaking change, which i'd like to avoid if possible.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants