You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm undecided whether I want to put this change through for two reasons:
I don't want to pollute intellisense with more ShouldBe extensions if they're not necessary. Perhaps there is another alternative syntax which is just as palatable and extends across many other scenarios, too
If we did add ShouldBeGreaterThanOrEqualTo, we should add a ShouldBeLessThanOrEqualTo at the same time to keep parity, so this particular commit doesn't have everything we'd need
Yes, I'm still thinking about the pollution.
Actually, at this stage, I'm inclined to be more liberal & start trimming later (I must admit, the project I'm using needed a GreaterThan - but not a LessThan).
I felt a bit sorry for the pull request and I'd already added some tests to it so I pulled it in.
I think we'll carry the pollution conversation forward and keep thinking about this.
Yep - need to be conscious of any Should methods added - removing them later is a breaking change, which i'd like to avoid if possible.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this method which exists in the NUnit core as well.