GenAI Utils: Adding Embedding metrics and events#1
Draft
Conversation
* Add a basic http OpAMP client * Add some docs and hook it into the system Still not building content * Add default value of 30 seconds to heartbeat message interval * Fix docs build * More docs improvements * Fix spellcheck * Remove local workaround * Generate workflows and add to release script * Fix typos in opamp lint commands * Fix requirements for pylint * Update opamp/opentelemetry-opamp-client/pyproject.toml * Recreate requirements * Add missing opentelemetry-api dependency * Fix tox test commands Drop opentelemetry api fixed version from requirements * Fix tox * Add baseline of vcrpy 7.0.0 * Ignore pb2 module in pylintrc * Bump pylint to match the version in core * Silence pylint warnings * Don't trace opamp client own http requests * Permit to pass a custom transport to client And a custom session to RequestsTransport * Don't bump pylint after all * Fix pylint * Try to typecheck opamp client * Bump version after rebase * Fix typecheck in client * Please pyright in strict mode * No need for functions and methods to be private since _opamp module is already private * Add missing protobuf package installation for typecheck * Fix docs generation * Fix pyright exclusion rule for proto Missed .pyi exclusion * Feedback * Don't flush the queue at exit * Log transport send exceptions * Update example to not assume that the config is in json format * Fix typo in exception * Looks like it's implementers * Add timeout to stop to forward to threads join * Clarify doc * Fix typo in var name * Add support for mTLS * Add helpers for handling of ReportFullState ServerToAgent flag Introducing basic handling of the ReportsEffectiveConfig capability * Remove backup file * Rewrite opamp_proto_codegen.sh to use uv * Make the package releasable independently * Send full state at connection * Add 3.14 test run * Add changelog entry * Add missing ReportsEffectiveConfig capability in documentation * Start version from 0.1b0 and re-record e2e tests * Record tests against opentelemetry-go --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…en-telemetry#4305) * fix(ci): eliminate SHA propagation flakiness in Core Contrib Test Each Core Contrib Test job was doing two separate git operations for the core repo: actions/checkout (uses GitHub internal API, always works) and then tox installing packages via git+https:// (hits public CDN, fails when SHA hasn't propagated yet). Fix by setting per-package env vars (CORE_REPO_API, CORE_REPO_SDK, CORE_REPO_SEMCONV, CORE_REPO_TEST_UTILS) in the CI workflow to point at the already-checked-out local copy, eliminating the second network clone entirely. Backward compatible: when the new vars are unset (local dev), they fall back to the existing git URL + subdirectory behavior. Fixes open-telemetry#4304 Assisted-by: Claude Sonnet 4.6 * fix: restore version header dropped during rebase Assisted-by: Claude Sonnet 4.6 * move CORE_REPO_* vars to top-level env block Use github.workspace context instead of a shell step to set the per-package local path env vars, as suggested in code review. Assisted-by: Claude Sonnet 4.6
* Remove unneded packages from docker tests * Bump some dependencies to avoid warning on deprecated crypto algos * Remove instrumentations that are not tested in docker-tests
…telemetry#4155) * Add sync streaming support for Anthropic instrumentation - Add support for Messages.create(stream=True) with StreamWrapper - Add support for Messages.stream() with MessageStreamManagerWrapper - Add MessageWrapper for non-streaming response telemetry - Rename MessageCreateParams to MessageRequestParams - Add comprehensive tests for sync streaming functionality * Add changelog entry for sync streaming support * Fix type checking errors with type: ignore comments - Add type: ignore[arg-type] for Union type narrowing in messages_create - Add type: ignore[return-value] for wrapper return types - Add type: ignore[return-value] for __exit__ returning None * Refactor Anthropic instrumentation to improve usage tracking and error handling - Introduce constants for provider name and cache token attributes. - Normalize stop reasons and aggregate cache token fields in MessageWrapper and StreamWrapper. - Enhance tests to validate input token aggregation and stop reason normalization. - Update cassettes for new request and response structures in streaming scenarios. * Refactor utility functions and test cases for improved readability and consistency - Simplify constant definitions and normalize function calls in utils.py. - Enhance test cases by removing unnecessary line breaks and improving formatting. - Ensure consistent usage of type hints and comments in test functions. * Refactor argument handling in assert_span_attributes function - Update the pylint directive to disable too-many-arguments warning for better clarity. - Maintain consistency in function signature and improve code readability. * Enhance tests for streaming message handling in Anthropic instrumentation - Update test cases to validate streaming behavior with various parameters, including token usage and stop reasons. - Introduce new cassettes for different scenarios, ensuring comprehensive coverage of streaming interactions. - Refactor existing tests for clarity and consistency in structure and assertions. * Update test_sync_messages.py to disable pylint warning for too-many-locals in test_stream_wrapper_finalize_idempotent function * Enhance StreamWrapper and MessageStreamManagerWrapper for idempotent finalization - Refactor finalization logic in StreamWrapper and MessageStreamManagerWrapper to ensure idempotent behavior during context exit. - Introduce new methods for successful and error finalization, improving clarity and reducing code duplication. - Add tests to validate double exit idempotency in streaming scenarios, ensuring only one span is emitted. - Update cassettes to reflect new request and response structures for streaming interactions. * Enhance Anthropic instrumentation to support content capture - Added logger_provider to TelemetryHandler for improved logging capabilities. - Implemented content capture logic in messages_create and messages_stream functions, allowing for the extraction of input messages and system instructions. - Introduced utility functions for content conversion and message handling in utils.py. - Updated tests to validate content capture functionality for both synchronous and streaming message creation. - Added new cassettes to reflect the changes in request and response structures for content capture scenarios. * Enhance tests for sync message creation in Anthropic instrumentation - Added checks for the presence of 'tools' and 'thinking' parameters in the installed anthropic SDK. - Updated test cases to skip if the SDK version does not support these parameters, ensuring compatibility with older versions. - Improved test robustness by dynamically determining parameter support. * Remove sensitive 'anthropic-organization-id' headers from test cassettes and update header scrubbing logic in tests. This enhances security by ensuring sensitive information is not recorded in test artifacts. * Refactor tests for sync message handling in Anthropic instrumentation - Simplified detection of 'tools' and 'thinking' parameters by directly accessing the _Messages class. - Improved readability of test cases by formatting input message loading. - Enhanced test function signatures for better clarity and maintainability. * Refactor utils.py for improved type safety and clarity - Added type casting for dictionary access to enhance type safety. - Simplified content block conversion logic to improve readability and maintainability. - Updated test cases to ensure consistent handling of content types and structures. * Enhance Anthropic instrumentation tests for EVENT_ONLY content capture - Introduced a new fixture to instrument Anthropic with EVENT_ONLY content capture mode. - Added tests to verify that content is not captured in span attributes while ensuring log events are emitted correctly. - Updated cassettes to reflect new request and response structures for EVENT_ONLY scenarios. - Enhanced existing tests to cover various content capture scenarios, including streaming and tool usage. * Refactor assertion in sync messages test for clarity - Simplified the assertion statement in the test_sync_messages_create_event_only_no_content_in_span function to improve readability. * Refactor content capture logic and enhance streaming tests for Anthropic instrumentation. * unsetting the model. * Remove instrumentation for Messages.stream() and refactor related code. Introduced MessageWrapper and StreamWrapper classes for telemetry handling. Updated tests to reflect changes in instrumentation behavior. * Refactor Anthropic instrumentation: reorganize imports, enhance utility functions, and update wrapper classes for better clarity and maintainability. Removed unused code and improved type safety in utility functions. Updated tests to reflect changes in the instrumentation behavior. * Add message extractors for Anthropic instrumentation. * Refactor message extractors in Anthropic instrumentation: reorganize imports and streamline finish reason normalization for improved clarity and maintainability. * Update test cassettes for Anthropic instrumentation: streamline request and response structures, enhance error handling scenarios, and ensure consistency in message formats across various test cases. Removed outdated data and improved clarity in test interactions. * Enhance Anthropic instrumentation: update MessageWrapper and StreamWrapper to include content capture logic, improve type safety with explicit casting, and streamline test cases for better clarity. Added new test for streaming response attributes and refined existing tests to ensure consistency in message handling. * Update test cassettes for Anthropic instrumentation: modify message IDs, timestamps, and token usage across various test cases. Refine content capture logic and ensure consistency in message formats, including adjustments to event data and headers for improved clarity and accuracy. * Rename StreamWrapper to MessagesStreamWrapper and update references in code and tests * Refactor type annotations in message extractors and wrappers for improved type safety. Replace 'Any' with 'object' in several function signatures and class attributes. Introduce logging for error handling in MessagesStreamWrapper to enhance instrumentation reliability. * Enhance type annotations in message extractors and patch for improved clarity and safety. Update function signatures to use specific types instead of 'object', including changes to parameters in extract_params, get_input_messages, and get_system_instruction. Refactor messages_create to ensure correct type handling for streaming and non-streaming responses. Additionally, streamline message handling in MessagesStreamWrapper for better performance and reliability. * Enhance type safety and error handling in message processing. Update function signatures in `messages_extractors.py` and `wrappers.py` to include specific types, improving clarity and reliability. Introduce handling for `None` values in `get_input_messages` and `get_system_instruction`. Refactor `MessagesStreamWrapper` to better manage usage updates and ensure correct type handling for streaming responses. Add new test cases for aggregating cache tokens and handling streaming errors. * Refactor assertions in test_sync_messages.py for improved readability. Simplify assertion statements by removing unnecessary parentheses, enhancing code clarity in cache token tests. * enforce strong typing system. * Update anthropic dependency version to 0.51.0 in pyproject.toml and requirements.oldest.txt for compatibility improvements. * Refactor usage token extraction to utilize a new UsageTokens dataclass for improved clarity and type safety. Update extract_usage_tokens function to return UsageTokens instead of a tuple, and adjust related invocations in MessageWrapper and MessagesStreamWrapper accordingly. * Update anthropic dependency version in uv.lock to 0.51.0 for compatibility improvements. * Add tests for should_capture_content function in test_events_options.py. * Enhance Anthropic instrumentation by adding logging support and refining type hints in messages_create function. Update test cassettes for improved accuracy and consistency in response data. * Refactor content capturing utility function to clarify its purpose in experimental mode. Update related tests to reflect the new function name and ensure accurate assertions for content capturing behavior. * Refactor import statements in patch.py for improved readability and organization. --------- Co-authored-by: Aaron Abbott <aaronabbott@google.com>
…ry#4280) * Add response wrappers for OpenAI Responses API streams. * Enhance docstrings for ResponseStreamWrapper and ResponseStreamManagerWrapper to include references to the OpenAI SDK source. This improves clarity on the functionality and origin of the wrappers. * Add wrappers for OpenAI Responses API streams and response stream managers in CHANGELOG.md * Refactor response handling in OpenAI response wrappers to improve event processing and error handling. Introduced conditional imports for response events and error types, ensuring compatibility with missing modules. Updated event processing logic to utilize a consolidated response events tuple. * Refactor OpenAI response wrappers to enhance error handling and event processing. Introduced context managers for safe instrumentation, improved import handling for response events, and streamlined response attribute extraction logic. * Add unit tests for ResponseStreamManagerWrapper to validate error handling and stream finalization behavior. * Remove unnecessary blank line in test_response_wrappers.py to improve code cleanliness. * Refactor event handling in ResponseStreamWrapper to simplify type checks for response events. Removed unnecessary conditional checks for event types, enhancing code clarity and maintainability. * Enhance ResponseStreamWrapper and ResponseStreamManagerWrapper with improved error handling and context management. Introduced ExitStack for better resource management and added NotImplementedError for unimplemented parse methods. Updated TODO comments for future refactoring with wrapt.ObjectProxy.
… upper bound to <3.0.0 (open-telemetry#4289) * opentelemetry-instrumentation-confluent-kafka: Add support for confluent-kafka 2.13.2 * chore: Losen confluent-kafka upper bound to <3.0.0 --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* Add support for wrapt 2.x - Update wrapt version constraint from '>=1.0.0, <2.0.0' to '>=1.0.0' in all affected packages - Replace ObjectProxy with BaseObjectProxy where iteration support is not needed - Add fallback import for wrapt 1.x compatibility (ObjectProxy as BaseObjectProxy) - Keep ObjectProxy usage in classes that implement __iter__ (botocore, aiopg) - Update CHANGELOG.md This change maintains backward compatibility with wrapt 1.x while enabling support for wrapt 2.x. BaseObjectProxy is the new base class in wrapt 2.x, while ObjectProxy is now a subclass that adds __iter__() support. Fixes open-telemetry#3903 Related to open-telemetry#3930 and open-telemetry#4082 * Restructure wrapt test requirements - Remove wrapt from base test-requirements.txt (installed via pyproject.toml) - Remove Deprecated from base test-requirements.txt (version conflicts with wrapt 2.x) - Create test-requirements-wrapt1.txt with wrapt<2.0.0 and Deprecated==1.2.14 - Create test-requirements-wrapt2.txt with wrapt>=2.0.0 and Deprecated>=1.2.18 - Update tox.ini to use requirements files instead of factor-based deps - Add Deprecated to lint environment deps This follows the pattern used by other packages (botocore, httpx) and resolves dependency conflicts where Deprecated 1.2.14 requires wrapt<2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: Resolve conflicts and add Wrapt 3 as upper bound * Add wrapt 1.x/2.x test matrix for all ObjectProxy-using instrumentations Extend the wrapt1/wrapt2 test matrix to all instrumentations that use wrapt.ObjectProxy or wrapt.BaseObjectProxy: botocore, dbapi, grpc, pika, aiopg, httpx, and asyncpg. Changes: - tox.ini: Add {wrapt1,wrapt2} factor to envlist for all 7 packages; update deps to reference per-version test-requirements files - botocore/pyproject.toml: Add missing wrapt dependency (>= 1.0.0, < 3.0.0) - All base test-requirements files: Remove pinned wrapt== and Deprecated== - New test-requirements-wrapt1.txt / test-requirements-wrapt2.txt files for each package (using Deprecated>=1.2.18 for wrapt2 to avoid conflict with Deprecated==1.2.14 which requires wrapt<2) - Regenerate GitHub Actions workflows (including new test_3.yml due to expanded job count) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix CI failures: ruff formatting and lint wrapt version pin - utils.py: reformat multi-condition if statement to satisfy ruff line length requirement (fixes generate/precommit CI jobs) - tox.ini: pin wrapt>=1.0.0,<2.0.0 for lint envs of botocore, dbapi, grpc, and sio-pika; with wrapt 1.x removed from base test-requirements, lint envs were getting wrapt 2.x which caused pylint no-member errors on __wrapped__ (a C-extension attribute not visible to static analysis) Also add Deprecated==1.2.14 to same lint envs for consistency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix remaining CI failures: unused imports and uv.lock - dbapi/__init__.py: remove unused bare 'import wrapt' (F401); the compat shim imports BaseObjectProxy directly from wrapt - grpc/_aio_server.py: remove unused 'import wrapt' (F401) and fix import ordering (I001) flagged by ruff pre-commit hook - uv.lock: regenerate after adding wrapt dependency to botocore pyproject.toml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix aiopg lint wrapt pin, uv.lock format, and ruff blank lines - tox.ini: pin wrapt>=1.0.0,<2.0.0 + Deprecated==1.2.14 for lint-instrumentation-aiopg; aiopg source uses __wrapped__ heavily and pylint's no-member error appeared when wrapt 2.x was installed - uv.lock: regenerate using pre-commit hook (uv v0.9.30) to fix trailing-slash format on registry URLs - httpx/test_httpx_integration.py: add blank line before try/except block (ruff I001/E303 formatting fix) - pika/utils.py: add blank line before try/except block (same ruff fix) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix pylint E0611: disable no-name-in-module for BaseObjectProxy compat shim pylint with wrapt 1.x installed reports E0611 ('No name BaseObjectProxy in module wrapt') when it sees the try/except ImportError compat shim, even though the except branch provides a fallback. Add a per-line pylint disable comment to suppress this false positive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix asyncpg test: use BaseObjectProxy compat shim for wrapt 2.x In wrapt 2.x, BoundFunctionWrapper no longer subclasses ObjectProxy (it subclasses BaseObjectProxy instead). Update the test to use the compat shim so isinstance checks pass with both wrapt 1.x and 2.x. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR review comments: add wrapt 2.0.0+ comments and fix CHANGELOG - Add '# wrapt 2.0.0+' comment above BaseObjectProxy import in all try/except compat shim blocks to clarify why the pattern is used - Fix CHANGELOG.md PR link from #XXXX to open-telemetry#4203 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * chore: Update changelog and workflows * Apply suggestions from code review Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * fix: Update workflows again * Apply suggestions from code review Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * Remove Deprecated version pins from test-requirements and tox.ini Deprecated>=1.2.14 was pinned because Deprecated==1.2.14 requires wrapt<2. Since pip automatically resolves compatible versions based on the wrapt constraint in each test env, explicit Deprecated pins are unnecessary. Remove them from all test-requirements-wrapt*.txt files and from lint env deps in tox.ini. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove stale .orig file leftover from rebase Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Move lint env wrapt pins from tox.ini into test-requirements files All dependencies should be managed via requirements.txt files rather than inline in tox.ini. Move wrapt>=1.0.0,<2.0.0 pins for lint environments into their respective test-requirements files: - instrumentation-grpc/test-requirements-1.txt - instrumentation-botocore/test-requirements-1.txt - instrumentation-dbapi/test-requirements.txt - instrumentation-aiopg/test-requirements.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Apply suggestions from code review * Update instrumentation/opentelemetry-instrumentation-botocore/test-requirements-1.txt * Update instrumentation/opentelemetry-instrumentation-grpc/test-requirements-1.txt * Update instrumentation/opentelemetry-instrumentation-dbapi/test-requirements.txt * Update instrumentation/opentelemetry-instrumentation-aiopg/test-requirements.txt * Address latest PR feedback: botocore compat shim, exact wrapt versions, lint env refs - botocore/bedrock_utils.py: apply BaseObjectProxy compat shim to ConverseStreamWrapper and InvokeModelWithResponseStreamWrapper (both classes define __iter__ so BaseObjectProxy is correct) - All test-requirements-wrapt1.txt: pin wrapt==1.17.3 (exact version) - All test-requirements-wrapt2.txt: pin wrapt==2.1.2 (exact version) - tox.ini lint envs: switch to -wrapt2.txt files so lint runs with wrapt 2.x; remove wrapt pin from base test-requirements files (grpc/test-requirements-1.txt, botocore/test-requirements-1.txt, dbapi/test-requirements.txt, aiopg/test-requirements.txt) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add pylint disable=no-member for __wrapped__ and abstract-method usages Add pylint: disable=no-member to all class definitions and usages of __wrapped__ that are invisible to pylint when using wrapt's C extension proxy types (BaseObjectProxy/ObjectProxy). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* Remove boto instrumentation * Add changelog * Run tox -e generate
To silence some Python 3.14 warnings.
* add schema_url to metrics * changelog * review * simplify further * simplify further --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…metry#4321) * fix: don't import module in unwrap if not already * Changelog * Make test clearer * Update CHANGELOG.md Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* pylint: use unnecessary-dunder-call instead of E1101 Since pylint 4 now raises a different error code * opentelemetry-instrumentation-sqlite3: fix pylint warnings Possibly using variable 'root_span' before assignment (possibly-used-before-assignment) Possibly using variable 'child_span' before assignment (possibly-used-before-assignment) * opentelemetry-instrumentation-botocore: silence a bunch of pylint warnings In the form of Possibly using variable '<var>' before assignment (possibly-used-before-assignment) * opentelemetry-instrumentation-redis: remove useless return spotted by pylint * opentelemetry-instrumentation-fastapi: silence some pylint warnings E0102: function already defined line 2034 (function-redefined) * opentelemetry-instrumentation-google-genai: fix pylint warnings Assisted by Cursor. * opentelemetry-instrumentation-openai-v2: fix pylint 4 errors Assisted by Cursor * opentelemetry-instrumentation-elasticsearch: fix pylint 4 errors Assisted by Cursor. * opentelemetry-instrumentation-pika: fix pylint 4 errors Assisted by cursor. * opentelemetry-instrumentation-starlette: fix pylint 4 errors * opentelemetry-instrumentation: fix pylint 4 errors Assisted by Cursor. * opentelemetry-util-http: fix pylint 4 errors
…pen-telemetry#4299) Bumps [django](https://github.com/django/django) from 4.2.17 to 4.2.29. - [Commits](django/django@4.2.17...4.2.29) --- updated-dependencies: - dependency-name: django dependency-version: 4.2.29 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…n-telemetry#4212) * feat: add support for capture_parameters to Psycopg2Instrumentor * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* Build list of required jobs in generate-workflow Dump the list of all the jobs in the same format that is required for configuration in opentelemetry-admin terraform config files so that we don't miss required jobs. * Serialize also misc jobs * Document what this script is about
* Add workflow type in genai utils * fixed errors * fixed errors * fixed test * fixed test * fixed precommit * moved to unreleased * reordered
…pen-telemetry#4302) * fix: Add recursion guard in LoggingHandler.emit to prevent deadlock LoggingHandler.emit() can deadlock when _translate() triggers internal logging (e.g., _clean_extended_attribute calling _logger.warning() for invalid attribute types). The warning re-enters the handler chain on the same thread, creating infinite recursion that prevents the handler lock from ever being released, blocking all other threads. This adds a ContextVar-based guard that detects re-entrant calls to emit() on the same thread and skips the recursive call, preventing the deadlock while preserving all application logs. Fixes open-telemetry/opentelemetry-python#3858 Relates to open-telemetry/opentelemetry-python#3560 Relates to open-telemetry/opentelemetry-python#4585 * Update CHANGELOG.md --------- Co-authored-by: Deepanshu Kartikey <kartikey406@gmail.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* feat: wrappers for async responses methods. * wip: updating changelog. * wip: refactoring for precommit and linting. * refactor: adding defensive guard against stream's response.
…emetry#4332) * chore(util-genai): migrate handler metrics test to TestBase * Formatting --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
…lemetry#1180) (open-telemetry#4259) * Fix gRPC client interceptor breaking bidirectional streaming (open-telemetry#1180) Route bidi (stream-stream) RPCs through `_intercept` instead of the generator-based `_intercept_server_stream`. The generator wrapper strips the grpc.Call/grpc.Future interface, causing downstream code (e.g. google.api_core.bidi.BidiRpc) to crash with: AttributeError: 'generator' object has no attribute 'add_done_callback' The fix adds `and not client_info.is_client_stream` to the condition in `intercept_stream()` so only unary-stream RPCs use the generator path. Includes a regression test verifying the bidi stream response preserves the grpc.Call interface (add_done_callback, cancel, is_active). Co-authored-by: Cursor <cursoragent@cursor.com> * Add gRPC status code attributes to error handling in client * Remove redundant status description from span error status The gRPC status code is already captured in the RPC_GRPC_STATUS_CODE attribute, making the description in span status unnecessary. * Update CHANGELOG.md * Update CHANGELOG.md * Add RPC_GRPC_STATUS_CODE assertions to client error tests Verify that error spans include the correct gRPC status code attribute (INVALID_ARGUMENT) in both sync and async client interceptor tests. --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* initial implementation for aiobotocore instrumentation * fix failing tests * add basic set of tests for aiobotocore instrumentation * update CHANGELOG.md * address comments and update tests to run with and without aiobotocore installed * update workflows and fix lock file * update tests * fix lint * Update botocore documentation to include aiobotocore * update bootstrap_gen.py * update botocore instrumentation test deps * update uv.lock * fix CHANGELOG.md and remove unused variable in tests --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
open-telemetry#4339) * refactor(docker-tests): replace SpanAttributes with semconv attributes Refs open-telemetry#3475 * update changelog for PR open-telemetry#4339 * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoGenAI Embedding Metrics, OpAMP Client, and Instrumentation Enhancements
WalkthroughsDescription• Added EmbeddingInvocation dataclass to GenAI types with embedding-specific attributes and metrics support • Refactored metrics recording in metrics.py to support both LLMInvocation and EmbeddingInvocation, with token metrics only recorded for LLM invocations • Added generic _start, _stop, and fail methods in handler.py supporting any GenAIInvocation subclass, plus new embedding context manager • Added embedding span and event handling utilities in span_utils.py including common attributes, span naming, and event emission • Added comprehensive embedding metrics tests validating duration recording, additional attributes, and error handling • Refactored tool call types: renamed ToolCall to ToolCallRequest, added ServerToolCall, ServerToolCallResponse, and WorkflowInvocation dataclasses • Enhanced Anthropic instrumentation with streaming support, message/stream wrappers, and extraction helpers • Added OpenAI v2 response stream wrappers with telemetry integration for handling streaming responses • Implemented OpAMP client with agent, message building, and transport layer for agent communication • Added aiobotocore async instrumentation with extension registry for AWS SDK instrumentation management • Multiple test suite additions for OpAMP, Anthropic, OpenAI, and botocore instrumentations • Updated semantic convention attribute imports across multiple test files (asyncpg, redis, celery, pymongo) • Fixed confluent-kafka and wrapt 2.0 compatibility issues • Removed deprecated boto instrumentation package Diagramflowchart LR
A["EmbeddingInvocation Type"] -->|"supports"| B["Metrics Recording"]
A -->|"supports"| C["Span & Event Handling"]
B -->|"duration only"| D["Embedding Metrics"]
C -->|"embedding-specific"| E["Span Utils"]
F["GenAI Handler"] -->|"generic methods"| G["LLM & Embedding Support"]
H["OpAMP Client"] -->|"agent communication"| I["Message Building"]
H -->|"transport"| J["HTTP with TLS"]
K["Anthropic Instrumentation"] -->|"streaming"| L["Message Wrappers"]
M["OpenAI v2"] -->|"streaming"| N["Response Wrappers"]
O["Botocore"] -->|"async support"| P["Aiobotocore Instrumentation"]
File Changes1. opamp/opentelemetry-opamp-client/src/opentelemetry/_opamp/proto/opamp_pb2.py
|
Code Review by Qodo
1. None provider attribute set
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+85
to
+88
| return { | ||
| GenAI.GEN_AI_OPERATION_NAME: invocation.operation_name, | ||
| GenAI.GEN_AI_PROVIDER_NAME: invocation.provider, | ||
| **{key: value for key, value in optional_attrs if value is not None}, |
There was a problem hiding this comment.
1. None provider attribute set 🐞 Bug ⛯ Reliability
_get_embedding_common_attributes() always includes gen_ai.provider.name even when EmbeddingInvocation.provider is None (the default). The new TelemetryHandler.embedding() path creates EmbeddingInvocation() without a provider, so stop()/fail() can attempt to apply an attribute with a None value to spans/events.
Agent Prompt
### Issue description
`_get_embedding_common_attributes()` unconditionally sets `gen_ai.provider.name` to `invocation.provider`, but `EmbeddingInvocation.provider` defaults to `None` and `TelemetryHandler.embedding()` creates an `EmbeddingInvocation()` with provider unset. This makes the embedding finish/error path propagate a `None` attribute value into span/event attribute sets.
### Issue Context
LLM common attributes already treat provider as optional (only include it when non-None). Embedding should behave the same.
### Fix Focus Areas
- util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py[73-89]
### Suggested change
Move provider into the `optional_attrs` filtered set (or explicitly guard it) so it is only included when not `None`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
…metry#4366) * Add support for workflow invocation in genAI utils handler * fix changelog * fixed errors * addressed comments * fixed precommit * made operation name immutable and added test * removed obsolete test * removed workflow specific method
* update readme * Update util/opentelemetry-util-genai/README.rst Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Update util/opentelemetry-util-genai/README.rst Co-authored-by: Liudmila Molkova <neskazu@gmail.com> --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
…telemetry#4365) * fix: map Python CRITICAL log level to OTel FATAL severity text in contrib handler The OTel specification defines the severity text for the highest severity range as "FATAL", but the contrib logging handler was passing through Python's native "CRITICAL" level name unchanged. This mirrors the fix made in open-telemetry/opentelemetry-python#5011 for the SDK handler. Related: open-telemetry/opentelemetry-python#4984 * Add CHANGELOG entry for CRITICAL -> FATAL severity text mapping * Update instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py --------- Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…pen-telemetry#4110) * Add _semconv set_db fns * lint * Changelog * semconv opt-in for sqlalchemy instr * use imports not hardcode * Update comment on comment-in-attr * Add tests * Changelog * Add migration status * Sqlalchemy http,database opt-in * meter schema_url * Add sqlalchemy _get_db_name_from_cursor * Add per-signal semconv opt-in schema url precedence; add sqlalchemy usage * Update _get_db_name coverage * More db_name_from_cursor cases * split to lint * _get_schema parses url from semconv * _get_* from cursor or conn * Add _semconv set_db_operation, used by sqlalchemy * get_db_name safer, update docker-test * Fix test * Add schema_url asserts * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…h to ensure file upload works (open-telemetry#4390) * Add check for if file exists to completion hook * Add tests * Add CHANGELOG entry * Try to delete file * Fix linter * Fix test * Ignore unknown function..
* tests(aiokafka): bump aiokafka 0.13 * tests(aiokafka): remove removed api_version argument from AIOKafkaProducer * fix(aiokafka): call serializers directly instead of _serialize * chore: add CHANGELOG entry for aiokafka 0.13 compatibility fix * tests(aiokafka): align tests to support python 3.9 * Apply suggestion from @xrmx --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* fix(aiokafka): close AIOKafkaProducer * fix(aiokafka): use AsyncMock to fix unawaited coroutine warning * docs(aiokafka): add CHANGELOG entry for test warning fixes * fix formatting * Apply suggestion from @xrmx --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…pen-telemetry#4375) Add is_http_instrumentation_enabled() check in OpenTelemetryMiddleware.__call__ so ASGI server spans are skipped when HTTP instrumentation is suppressed. Every other HTTP instrumentor (client and server) already honors this flag. ASGI was the only one that did not. Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* port alls-green to -contrib Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix typo Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --------- Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
…metry#4346) * wip: wrappers for async message wrappers. * wip: replacing the invocation response attributes with new attributes function. * wip: cleaning up the function. * polish: cleaning up the response attribution using event accumulation method. * wip: rearranging the code in anthropic wrappers. * polish: added a changelog. * wip: fixing lint, typecheck and precommit failures. * wip: keeping anthropic wrapper same as openai wrapper. * wip: removing redundant truthy checks for required attributes.
* wip: pydantic based responses api attributes extraction. * polish: fixing the linting around files. * refactor: update changelog. * polish: removing pydantic hard dependency and making pydantic version compatible with openai supported version. * wip: tox validation for pydantic 1.x version. * generated new workflows. * adding the pydantic test to new test file and removing old files. * wip: generated workflows. * wip: removed unwanted truthiness checks and simplified the test suite. * polish: fixed precommit. --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
shuningc
force-pushed
the
addingEmbeddingMetric
branch
from
e6216e4 to
68d328f
Compare
Group all emeritus into one to keep consistent for script cleanup
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds metrics and events telemetry for [EmbeddingInvocation], aligning with OpenTelemetry semantic conventions. Previously, embedding invocations only emitted spans - now they also emit duration metrics and operation details events.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added 3 new tests for embedding metrics:
[test_stop_embedding_records_duration_only] - verifies duration is recorded but token metrics are NOT
[test_stop_embedding_records_duration_with_additional_attributes] - verifies server address, port, custom attributes, and response model are included
[test_fail_embedding_records_error_and_duration] - verifies error path records
error.type and duration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.