Add endpoints for event based decryption triggers #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: it changed from 'use 3rd party tooling' but does not mention, that the provided compiler implementation is opinionated, and 3rd party tooling could provide more flexible event triggers. Namely triggers that allow for some parameters to be omitted, e.g. topic0
… get_data_for_encryption endpoint
ylembachar
reviewed
Jan 8, 2026
ylembachar
reviewed
Jan 12, 2026
jannikluhn
reviewed
Jan 12, 2026
Whitelisting only certain contracts for event based decryption triggers does not help with reducing or limiting load on keypers. Instead, if there is need for it, we would need to limit the total number of active event based triggers.
The parameter is not necessary for event based identities, because it can be derived from signing key.
The specialized func was used in only one place and could produce semantically incorrect results. I inlined the switch statement and added an explicit error case on default.
In order to avoid overflow for large integers, the 'number' argument is parsed from a decimal string.
ylembachar
approved these changes
Jan 14, 2026
Collaborator
ylembachar
left a comment
ylembachar
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for the updates. Added a comment about a potential contract update.
16 tasks
Collaborator
|
Added this issue to track a few discussions and todos post-deployment on Chiado: #84 |
ylembachar
reviewed
Jan 14, 2026
| lp.ValuePredicate.Op = shs.BytesEq | ||
| lp.ValuePredicate.ByteArgs = [][]byte{Align(val)} | ||
| length = uint64(len([]byte(arg.Bytes)) / 32) | ||
| length = uint64(len(val) / shs.Word) |
Collaborator
There was a problem hiding this comment.
We should align val here as well, as otherwise, the value is not padded to 32 bytes, and calculation will not work for less than 32 byte words. A unit test would be helpful here to catch these cases. I'll add this to the improvements needed, for now, we can just deploy and pad manually as a workaround.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements API endpoints for event based decryption triggers.
WIP/TODO:
TODOcommentsRegisterEventIdentityis untested so far/compile_event_trigger_definition,/register_event_trigger) to rate limitingFixes #74
See also https://github.com/shutter-network/shutter-api?tab=readme-ov-file#1b-register-an-identity-with-event-based-decryption-triggers-wip