chore: drop migrations older than v1.0.0 #2044
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
force-pushed
the
chore/drop-old-migrations
branch
2 times, most recently
from
6bbb779 to
fdab8fa
Compare
There was a problem hiding this comment.
Pull request overview
This PR drops all migrations older than v1.0.0 and removes deprecated resource types that were only maintained for those migrations. The goal is to simplify the codebase by requiring users to upgrade to v1.0.0 first before upgrading to newer versions, rather than supporting direct upgrades from very old versions.
Key changes:
- Replaced 46 old migration callbacks with a
gapErrorfunction that returns an error message - Removed deprecated resource types:
ClusterMachineTemplate,ExtensionsConfigurationStatus, andDeprecatedLinkCounter - Deleted migration helper functions and tests for old migrations
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/backend/runtime/omni/migration/migrations.go |
Replaced old migration callbacks with gapError function |
internal/backend/runtime/omni/migration/manager.go |
Updated migration list to use gapError for pre-v1.0.0 migrations |
internal/backend/runtime/omni/migration/migration_test.go |
Removed tests for old migrations, kept tests for v1.0+ migrations |
internal/backend/runtime/omni/migration/helpers.go |
Deleted file containing helper functions only used by old migrations |
internal/backend/runtime/omni/migration/compat.go |
Deleted file with deprecated constants and helper functions |
internal/backend/runtime/omni/migration/deprecated_resources_test.go |
Deleted test file for deprecated resources |
internal/backend/runtime/omni/state_access.go |
Removed references to deprecated resource types |
internal/integration/auth_test.go |
Removed test cases for deprecated resources |
client/pkg/omni/resources/omni/cluster_machine_template.go |
Deleted deprecated ClusterMachineTemplate resource definition |
client/pkg/omni/resources/omni/extensions_configuration_status.go |
Deleted deprecated ExtensionsConfigurationStatus resource definition |
client/pkg/omni/resources/siderolink/linkcounter.go |
Deleted deprecated DeprecatedLinkCounter resource definition |
client/api/omni/specs/omni.proto |
Reserved field 1 in ClusterSpec, removed deprecated message types |
frontend/src/api/resources.ts |
Removed deprecated resource type constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
utkuozdemir
force-pushed
the
chore/drop-old-migrations
branch
from
fdab8fa to
9124766
Compare
Drop old migrations and deprecated types which were kept only for the migrations. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
force-pushed
the
chore/drop-old-migrations
branch
from
9124766 to
dc2b1c9
Compare
smira
approved these changes
Dec 22, 2025
Member
smira
left a comment
smira
left a comment
There was a problem hiding this comment.
does it fail if we try to start from pre-1.0.0 version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop old migrations and deprecated types which were kept only for the migrations.