chore: move graceful config rollout logic to the lowest controller level #2069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
graceful-rollout-machine-config-status
branch
from
e3835f0 to
2e7580e
Compare
Now graceful config rollout is handled by the `ClusterMachineConfigStatusController`. It calculates the available update quota by adding finalizers on the `ClusterMachine` resources. By counting the resources with the finalizers it tracks the remaining quota. It now also calculates the pending changes which are not yet applied to the machine in the `MachinePendingUpdates`. Pending changes are not yet shown in the UI anywhere. Fixes: siderolabs#1929 Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Unix4ever
force-pushed
the
graceful-rollout-machine-config-status
branch
from
2e7580e to
ed7e446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now graceful config rollout is handled by the
ClusterMachineConfigStatusController.It calculates the available update quota by adding finalizers on the
ClusterMachineresources. By counting the resources with the finalizers it tracks the remaining quota.It now also calculates the pending changes which are not yet applied to the machine in the
MachinePendingUpdates.Pending changes are not yet shown in the UI anywhere.
Fixes: #1929