Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and refactoring to the Python
dp-clientlibrary and its documentation, focusing on expanding the supported user API endpoints, enforcing stricter validation, and improving testability and maintainability. The changes also clarify API usage and validation rules in the documentation, and add a comprehensive test matrix for both unit and component tests.API and Client Improvements:
UsersApiandDPClientto support all user CRUD operations (create,retrieve,list,update,partial_update,destroy), with strict id immutability enforced and robust endpoint validation at initialization. The client now injects the path id for PUT if omitted and rejects PATCH bodies containingid. [1] [2] [3]metadata_clientand clearer error handling. [1] [2] [3] [4]dp-client, including__all__exports for top-level symbols and more precise type hints throughout.Documentation and Usability:
README.mdto clarify the API endpoints, validation rules (notably id immutability), and usage patterns for the client, including detailed examples for all CRUD operations. [1] [2]Testing and DB Helpers:
psycopg2connections.Grouped by Theme:
API Expansion and Validation
UsersApiandDPClient, enforcing id immutability and robust endpoint validation at initialization. [1] [2] [3]Documentation and Testing
Codebase and Typing Improvements