python(feat): Sift Client Ingestion#370
Conversation
|
General thoughts while you work on tests etc:
|
|
|
Does this with in without async as well? |
I talked with Luck about this. For now, no. We can add that in once a customer asks for it, but in general, we expect async to be faster, so we should steer customers in that direction. |
f35d263 to
946fd7b
Compare
alexluck-sift
left a comment
There was a problem hiding this comment.
Generally looks very good! A few comments before merge
Adds ingestion to SiftClient, using sift_stream_bindings to interface with the underlying SiftStream.
Example
Output from above code
Errors returned from SiftStream will be raised as exceptions in python that can be handled
For example, if modifying an already existing flow incorrectly