python(refactor): removed google.api and protoc_gen modules from buf#543
Merged
python(refactor): removed google.api and protoc_gen modules from buf#543
Conversation
wei-qlu
changed the title
solidiquis
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
sift_stack_py currently vendors generated Python bindings for three external proto dependencies under python/lib/: buf/validate/, google/api/, and protoc_gen_openapiv2/. These land there as a side effect of buf generate compiling all deps alongside our own protos.
This PR scopes Python codegen to sift/** and buf/** in scripts/gen.sh so google/api/ and protoc_gen_openapiv2/ are no longer generated, deletes the stale vendored copies, and adds googleapis-common-protos and protoc-gen-openapiv2 as runtime dependencies in pyproject.toml so generated sift code resolves those modules from PyPI at runtime. buf/validate/ is left vendored for now because Buf publishes the protovalidate runtime to PyPI but intentionally withholds the generated buf.validate.validate_pb2 bindings, distributing them only via the Buf Schema Registry at https://buf.build/gen/python. The buf.yaml deps are unchanged since buf still needs those .proto source files at codegen time.
Verified by running make gen-python cleanly and passing tests in a fresh venv.