sift(refactor): remove protovalidate from client-side protos#545
Merged
sift(refactor): remove protovalidate from client-side protos#545
Conversation
solidiquis
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed (buf.validate.field) annotations and the buf/validate/validate.proto import from the 7 .proto files using them, dropped buf.build/bufbuild/protovalidate from protos/buf.yaml, removed the buf/** pass from scripts/gen.sh, regenerated the Python bindings, and deleted python/lib/buf/. Server-side validation is unaffected.
Validation
Verified that buf.validate is not referenced anymore. Generated the protos and confirmed that a new build only contains sift/, sift_client/, and sift_py/. Importing all 7 affected modules in a clean venv works as normal and passes all related tests.