Skip to content

python(fix): lazy-import h5py and nptdms so base install doesn't require them #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wei-qlu merged 1 commit into from
Apr 30, 2026
+14 −2
Merged

python(fix): lazy-import h5py and nptdms so base install doesn't require them #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions python/lib/sift_client/resources/data_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
from sift_client._internal.low_level_wrappers.data_imports import DataImportsLowLevelClient
from sift_client._internal.util.executor import run_sync_function
from sift_client._internal.util.file import extract_parquet_footer, upload_file
from sift_client._internal.util.hdf5 import detect_hdf5_config
from sift_client._internal.util.tdms import detect_tdms_config
from sift_client.resources._base import ResourceBase
from sift_client.sift_types.asset import Asset
from sift_client.sift_types.data_import import (
Expand Down Expand Up @@ -240,8 +238,22 @@ async def detect_config(
data_type_key = _resolve_data_type_key(path.suffix.lower(), data_type)

if data_type_key == DataTypeKey.HDF5:
try:
from sift_client._internal.util.hdf5 import detect_hdf5_config
except ImportError as e:
raise RuntimeError(
"h5py is required for HDF5 import. "
"Install it via `pip install sift-stack-py[hdf5]`."
) from e
return await run_sync_function(lambda: detect_hdf5_config(path))
if data_type_key == DataTypeKey.TDMS:
try:
from sift_client._internal.util.tdms import detect_tdms_config
except ImportError as e:
raise RuntimeError(
"npTDMS is required for TDMS import. "
"Install it via `pip install sift-stack-py[tdms]`."
) from e
return await run_sync_function(lambda: detect_tdms_config(path))

is_parquet = data_type_key in (
Expand Down
Loading