Skip to content

Updating invite links now that Bitly supports HTTPS - Yay!#5467

Closed
jonathancross wants to merge 1 commit into
signalapp:masterfrom
jonathancross:patch-1
Closed

Updating invite links now that Bitly supports HTTPS - Yay!#5467
jonathancross wants to merge 1 commit into
signalapp:masterfrom
jonathancross:patch-1

Conversation

@jonathancross
Copy link
Copy Markdown
Contributor

@jonathancross jonathancross commented Apr 28, 2016

  • I have read how to contribute to this project
  • I have signed the Contributor Licence Agreement
  • I am following the Code Style Guidelines
  • I have tested my contribution on these devices:
    • Chrome 49.0.2623.105 Android
    • Orfox Android (Redirect works to whispersystems.org, but no further because redirects blocked)
    • Chrome 50.x Mac
    • Tor Browser 5.5.4 (based on Mozilla Firefox 38.7.1)
  • My contribution is fully baked and ready to be merged as is
  • I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

// FREEBIE


Invite links now work over https -- yes I tested :-)

fixes #4060

More info: EFForg/https-everywhere#4505 and on stackexchange.

@jonathancross
Copy link
Copy Markdown
Contributor Author

Hi there, just checking if there is anything else needed here?

@2-4601
Copy link
Copy Markdown
Contributor

2-4601 commented May 11, 2016

Hi there, just checking if there is anything else needed here?

Your PR is a two character change. Did you understand this checklist item:

  • I have made the choice whether I want the [BitHub reward]

Seems like half of that is missing. See original template.

@jonathancross
Copy link
Copy Markdown
Contributor Author

@2-4601 I added FREEBIE to this conversation, but now trying to see how to change my commit message.

@2-4601
Copy link
Copy Markdown
Contributor

2-4601 commented May 11, 2016

At this stage it's probably not a big sin to amend and force push with a new commit message.
Btw, there's a backlog of over thirty PRs atm so there isn't much one can do except wait patiently :)

@jonathancross
Copy link
Copy Markdown
Contributor Author

Thanks @2-4601. All good now.

@moxie0 moxie0 closed this May 20, 2016
@jonathancross jonathancross deleted the patch-1 branch May 21, 2016 08:03
@nrizzio
Copy link
Copy Markdown
Contributor

nrizzio commented May 23, 2016

#4060 can be closed now that this is fixed (it's locked and still open currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invite link uses insecure plain http

4 participants