Updating invite links now that Bitly supports HTTPS - Yay!#5467
Closed
jonathancross wants to merge 1 commit into
Closed
Updating invite links now that Bitly supports HTTPS - Yay!#5467jonathancross wants to merge 1 commit into
jonathancross wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi there, just checking if there is anything else needed here? |
Contributor
Your PR is a two character change. Did you understand this checklist item:
Seems like half of that is missing. See original template. |
Contributor
Author
|
@2-4601 I added |
Contributor
|
At this stage it's probably not a big sin to amend and force push with a new commit message. |
Both invite links now work over `https` -- yes I tested :-) More info: EFForg/https-everywhere#4505 and on [stackexchange](http://webmasters.stackexchange.com/questions/87163/do-bitly-branded-short-domains-support-https/92407#92407). PS: https://sgnl.link/1IvurmD also works. Fixes #4060 // FREEBIE
Contributor
Author
|
Thanks @2-4601. All good now. |
Contributor
|
#4060 can be closed now that this is fixed (it's locked and still open currently). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// FREEBIE
Invite links now work over
https-- yes I tested :-)fixes #4060
More info: EFForg/https-everywhere#4505 and on stackexchange.