Move beacon pool http api to its own separate module #8543
Merged
+563
−422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
changed the title
jimmygchen
added
ready-for-review
pawanjay176
approved these changes
Dec 5, 2025
jimmygchen
added
ready-for-merge
pawanjay176
added
ready-for-review
Co-authored-by: pawanjay176 <pawandhananjay@gmail.com>
pawanjay176
force-pushed
the
refactor-http-api-3
branch
from
5c537ec to
ed5613a
Compare
pawanjay176
added
ready-for-merge
Merge Queue Status✅ The pull request has been merged This pull request spent 41 minutes 55 seconds in the queue, including 40 minutes 16 seconds running CI. Required conditions to merge
|
Member
|
Forgot to reque this after mergify recovered. Queuing again now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Continuation of:
Moving
/beacon/poolendpoints out ofhttp_apito a separation module. This should improve code maintainability, incremental compilation time and rust analyzer performance.This is a tedious but straight forward change, so we're going with a pair & insta-merge approach to avoid painful & slow async review