Add unit tests for oidc-EmailFromIDToken method#413
Merged
Conversation
nsmith5
approved these changes
Feb 16, 2022
Contributor
nsmith5
left a comment
nsmith5
left a comment
There was a problem hiding this comment.
This looks fantastic! Congrats on your first contribution to Fulcio 🥇
| "unsafe" | ||
| ) | ||
|
|
||
| // reflect hack because "claims" field is unexported by oidc IDToken |
Contributor
There was a problem hiding this comment.
Nit: maybe link to the upstream issue about exporting those fields in case we can remove this once it gets closed?
Contributor
Author
There was a problem hiding this comment.
Added the link to the PR opened in the upstream project - coreos/go-oidc#329
Signed-off-by: Elizabeth Thomas <elizabeth.thomas@target.com>
dlorenc
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Elizabeth Thomas email2eliza@gmail.com
Summary
Adding unit tests for EmailFromIDToken method in oauthflow.oidc
Ticket Link
Fixes #405
Release Note