Pause video when app goes in background #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
requested changes
Nov 30, 2017
| } | ||
|
|
||
| class _VideoAppLifeCycleObserver extends WidgetsBindingObserver { | ||
| bool wasPlayingBeforePause = false; |
| switch (state) { | ||
| case AppLifecycleState.paused: | ||
| wasPlayingBeforePause = controller.value.isPlaying; | ||
| if (controller.value.initialized) controller.pause(); |
Collaborator
There was a problem hiding this comment.
Please format single-statement if branches consistently.
Worse: if controller is not yet initialized, we lose the pause signal and may start playing while in background.
Owner
Author
There was a problem hiding this comment.
I removed the conditional. The controller should take care of delaying the play message till after initialisation is done.
sigurdm
pushed a commit
that referenced
this pull request
May 15, 2018
Camera Plugin: Refactored UI code of example app and improved it a li…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.