Skip to content

DEV-2933: pwm: ipq: fix period calculation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baruchsiach merged 1 commit into from
Dec 14, 2021
Merged

DEV-2933: pwm: ipq: fix period calculation #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions drivers/pwm/pwm-ipq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ static int ipq_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
unsigned int pre_div, pwm_div, best_pre_div, best_pwm_div;
unsigned long rate = clk_get_rate(ipq_chip->clk);
u64 period_ns, duty_ns, period_rate;
u64 min_diff;

if (state->polarity != PWM_POLARITY_NORMAL)
return -EINVAL;
Expand All @@ -123,12 +124,12 @@ static int ipq_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
/* Initial pre_div value such that pwm_div < IPQ_PWM_MAX_DIV */
pre_div = div64_u64(period_rate,
(u64)NSEC_PER_SEC * (IPQ_PWM_MAX_DIV + 1));
min_diff = period_rate;

for (; pre_div <= IPQ_PWM_MAX_DIV; pre_div++) {
long long diff;
u64 min_diff = period_rate;

pwm_div = div64_u64(period_rate,
pwm_div = DIV64_U64_ROUND_UP(period_rate,
(u64)NSEC_PER_SEC * (pre_div + 1));
/* pwm_div is unsigned; the check below catches underflow */
pwm_div--;
Expand Down