Open
Conversation
added 4 commits
November 2, 2017 23:23
...ter parsers to support new Param type
... and some cleanup
Member
|
This looks like a good change, thanks for working on this! I don't have much time now but I'll try to do a proper review over the weekend. Feel free to ping me next week if you didn't hear anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #69 I've made params applicative which greatly simplifies the definitions of range and (IMHO) gives much more flexibility to this library.
NOTE: This pattern can also be applied to
Headeras it has the same format asParam