Prevent Flush from deadlocking

[tombogle]

Also upgraded to latest version of Segment's Analytics package
Misc code cleanup in Analytics.cs

---

This change is 

[tombogle]

This "fix" is a kludge. I have reported the problem to Segment in hopes of a fix: segmentio/Analytics.NET#200

[andrew-polk]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @jasonleenaylor and @tombogle)

---

SampleAppWithForm/Form1.cs line 31 at r1 (raw file):

				$"Submitted: {Segment.Analytics.Client.Statistics.Submitted}; " +
				$"Failed:  {Segment.Analytics.Client.Statistics.Failed}");
			// This allows us to illustrate the deadlock problem.

Want to reference an issue and/or the code used to work around it?

---

src/DesktopAnalytics/Analytics.cs line 578 at r1 (raw file):

				// So instead of calling Flush, if there are events in the queue, we just wait a little while.
				// The default timeout on the client is 5 seconds, so probably we should never need to wait
				// longer than that.

Want to reference the reported issue here for future reference?

---

src/DesktopAnalytics/Analytics.cs line 586 at r1 (raw file):

						break;
					totalWait += 2500;
					Thread.Sleep(2500);

2.5 seconds seems like a long time to wait (I assume the user experiences this as the app taking a long time to close?)

---

src/DesktopAnalytics/Analytics.cs line 636 at r1 (raw file):

				// helpful if someone starts using an app built before the OS is released. Anything that
				// your app has a manifest which says it supports the OS it is running on.  This is not
				// After Windows 8 the Environment.OSVersion started misreporting information unless

This comment got messed up.

[jasonleenaylor]

src/DesktopAnalytics/Analytics.cs line 586 at r1 (raw file):

Previously, andrew-polk wrote…

2.5 seconds seems like a long time to wait (I assume the user experiences this as the app taking a long time to close?)

It seems like a long time, but since it will only happen if the app is closed when events are queued it might be fine.

[tombogle]

src/DesktopAnalytics/Analytics.cs line 586 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

It seems like a long time, but since it will only happen if the app is closed when events are queued it might be fine.

Added a comment to explain this. (After more experimentation, I determined that it was occasionally possible to end up with a single wait cycle of only a second, so I just decided to make it simple and wait a half second at a time. But most of the time it takes 2-4 seconds.)

[tombogle]

Reviewable status: 3 of 11 files reviewed, 4 unresolved discussions (waiting on @andrew-polk and @jasonleenaylor)

---

src/DesktopAnalytics/Analytics.cs line 578 at r1 (raw file):

Previously, andrew-polk wrote…

Want to reference the reported issue here for future reference?

Done.

---

src/DesktopAnalytics/Analytics.cs line 636 at r1 (raw file):

Previously, andrew-polk wrote…

This comment got messed up.

Fixed

---

SampleAppWithForm/Form1.cs line 31 at r1 (raw file):

Previously, andrew-polk wrote…

Want to reference an issue and/or the code used to work around it?

Done.

[jasonleenaylor]

Reviewed 4 of 7 files at r1, 6 of 7 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @andrew-polk)

[andrew-polk]

Reviewed 6 of 7 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)