Skip to content

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Jan 27, 2026

This fixes https://jira.sil.org/browse/LT-22230. Whenever styles are edited then RefreshPopupWindowFonts is published. ParserListener subscribes to RefreshPopupWindowFonts and calls SetFont on each of the parser report windows to update the font. I changed the XAML files so that they would work with different font sizes. I also had to make ShowParserReport use the Pub/Sub model because it couldn't be a static function anymore because I needed m_parserReportDialogs to keep track of the parser reports.


This change is Reviewable

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 files and made 1 comment.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).


Src/LexText/ParserUI/ParserListener.cs line 847 at r1 (raw file):

				ReadParserReports();
				// Create parser reports window.
				m_parserReportsDialog = new ParserReportsDialog(m_parserReports, m_mediator, m_cache, m_propertyTable, m_defaultComment);

Instead of using Pub/Sub to get to the ParserListener.ShowParserReport() can you add a ParserListener parameter to the ParserReportDialog constructor and the ParserReportsDialog constructor. They both look like they are only called from ParseListener so I think you can pass in 'this'.

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 5 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants