Make workflow safe to run locally (no git reset)#169
Merged
Conversation
If running the workflow locally using `act` or `docker run`, we don't want any `git reset --hard HEAD` commands being run on the mounted repo, as that could easily blow away uncommitted work in the developer's own copy of the repo. So we mount the repo somewhere else, and then copy the repo into a working location that we can safely run `git reset` inside. Note that this commit won't build, as the packages aren't going to be collected properly. The package location will be changed later.
FLExBridge dependencies were getting unpacked automatically by the Docker COPY command, but now that they're being copied from within the build, we need to actually unpack them ourselves.
Using a sentinel file that should still exist after build
This reverts commit f1b233b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If running the workflow locally using
actordocker run, we don't want anygit reset --hard HEADcommands being run on the mounted repo, as that could easily blow away uncommitted work in the developer's own copy of the repo. So we mount the repo somewhere else, and then copy the repo into a working location that we can safely rungit resetinside.This change is