-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add NuGet packaging step to CI/CD workflow #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91b81a2 to
2cf5e84
Compare
|
Note to self: Might be a good idea to push PR builds to https://int.nugettest.org/ (API endpoint is at https://apiint.nugettest.org/v3/index.json rather than the standard one). Microsoft makes no guarantees about data preservation, but I expect they would stick around for at least a few hours before being deleted, which would allow other code to consume them for testing purposes. For example, I could add a new feature to LfMergeBridge in a PR to the flexbridge repo, then consume a NuGet package in LfMerge and be able to test the code right away, without having to mess with local NuGet feeds. See https://learn.microsoft.com/en-us/nuget/nuget-org/nuget-org-faq#managing-packages-on-nuget-org for where I got the idea from. |
For now this just uploads to build artifacts; we will upload to nuget.org once we've tested that the packages are built correctly.
Requires a GitHub secret named NUGET_APIKEY before it will work. Currently commented out so it won't break the build until that secret is uploaded to the GitHub repo.
Don't actually publish, but show the lines that would have run. This also tests whether we can use the "if" condition to skip running the step in the absence of an API key.
No longer needed now that testing is completed.
It's an org secret: no need to add it to the repo, it's already there.
4967645 to
7b81fc4
Compare
|
Workflow failed because our API key isn't registered on int.nugettest.org. We may want to get that taken care of at some point, because it would be really nice to have the ability to reference NuGet packages built from PRs. |
We'll do this in a separate PR.
megahirt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #400.
This PR moves NuGet publishing to GitHub actions and removes the Appveyor CI. Appveyer was only responsible for NuGet publishing, so this consolidates CI to only use GHA.
This change is