Skip to content

Conversation

@rmunn
Copy link
Contributor

@rmunn rmunn commented Jul 1, 2024

Fixes #400.

This PR moves NuGet publishing to GitHub actions and removes the Appveyor CI. Appveyer was only responsible for NuGet publishing, so this consolidates CI to only use GHA.


This change is Reviewable

@rmunn rmunn self-assigned this Jul 1, 2024
@rmunn rmunn force-pushed the feat/nuget-packages-in-ci-cd branch 6 times, most recently from 91b81a2 to 2cf5e84 Compare July 2, 2024 03:53
@rmunn rmunn marked this pull request as ready for review July 2, 2024 04:11
@rmunn rmunn requested a review from jasonleenaylor July 2, 2024 08:09
@rmunn
Copy link
Contributor Author

rmunn commented Jul 4, 2024

Note to self: Might be a good idea to push PR builds to https://int.nugettest.org/ (API endpoint is at https://apiint.nugettest.org/v3/index.json rather than the standard one). Microsoft makes no guarantees about data preservation, but I expect they would stick around for at least a few hours before being deleted, which would allow other code to consume them for testing purposes. For example, I could add a new feature to LfMergeBridge in a PR to the flexbridge repo, then consume a NuGet package in LfMerge and be able to test the code right away, without having to mess with local NuGet feeds.

See https://learn.microsoft.com/en-us/nuget/nuget-org/nuget-org-faq#managing-packages-on-nuget-org for where I got the idea from.

rmunn and others added 6 commits July 8, 2024 10:12
For now this just uploads to build artifacts; we will upload to
nuget.org once we've tested that the packages are built correctly.
Requires a GitHub secret named NUGET_APIKEY before it will work.
Currently commented out so it won't break the build until that secret is
uploaded to the GitHub repo.
Don't actually publish, but show the lines that would have run. This
also tests whether we can use the "if" condition to skip running the
step in the absence of an API key.
No longer needed now that testing is completed.
It's an org secret: no need to add it to the repo, it's already there.
@rmunn
Copy link
Contributor Author

rmunn commented Jul 9, 2024

Workflow failed because our API key isn't registered on int.nugettest.org. We may want to get that taken care of at some point, because it would be really nice to have the ability to reference NuGet packages built from PRs.

Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmunn rmunn merged commit 8680485 into develop Jul 9, 2024
@rmunn rmunn deleted the feat/nuget-packages-in-ci-cd branch July 9, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move FlexBridge NuGet packaging build to GitHub Actions

3 participants