Add minimal logging of UnitOfWork activity #360
Draft
+77
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add logger to IOC container when LCM_TransactionLogPath environment variable is defined. * Use logging to add breadcrumbs to trace UOW calls. * This is a first step to try and track down some intermittent failures in FieldWorks unit tests.
papeh
commented
Jan 29, 2026
Contributor
Author
papeh
left a comment
papeh
left a comment
There was a problem hiding this comment.
I see this was added three years ago for debugging; is it still needed?
| protected virtual void Dispose(bool disposing) | ||
| { | ||
| Debug.WriteLineIf(!disposing, "****** Missing Dispose() call for " + GetType() + ". *******"); | ||
| lock (m_stream) |
Contributor
Author
There was a problem hiding this comment.
did you mean to lock (m_lock)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is