Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented May 5, 2025

Fixes #163

Let me know if more examples should be added.


This change is Reviewable

…ple of marker behavior to paratext_usfm.ipynb
@Enkidu93 Enkidu93 requested a review from ddaspit May 5, 2025 19:14
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)


samples/paratext_usfm.ipynb line 21 at r1 (raw file):

     "output_type": "stream",
     "text": [
      "Defaulting to user installation because normal site-packages is not writeable\n",

You can clear this cell.

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit)


samples/paratext_usfm.ipynb line 21 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You can clear this cell.

Done.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (962ca36) to head (1944d89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         277      277           
  Lines       16632    16632           
=======================================
  Hits        14743    14743           
  Misses       1889     1889           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 merged commit 7a4bde9 into main May 7, 2025
14 checks passed
@Enkidu93 Enkidu93 deleted the usfm_behavior_example_updates branch May 7, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs for UpdateUsfmTextBehavior

4 participants