Skip to content

Conversation

@isaac091
Copy link
Collaborator

@isaac091 isaac091 commented May 23, 2025

This change is Reviewable

@isaac091 isaac091 requested review from Enkidu93 and ddaspit May 23, 2025 03:50
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (0354cc7) to head (f6f590b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   88.87%   88.88%           
=======================================
  Files         282      282           
  Lines       16951    16961   +10     
=======================================
+ Hits        15065    15075   +10     
  Misses       1886     1886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@isaac091 isaac091 merged commit 9f3b23e into main May 23, 2025
14 checks passed
@isaac091 isaac091 deleted the embed_position branch May 23, 2025 16:34
benjaminking pushed a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants