Skip to content

Conversation

@ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jun 2, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.91%. Comparing base (17fe20d) to head (3f93d92).

Files with missing lines Patch % Lines
machine/corpora/update_usfm_parser_handler.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   88.89%   88.91%   +0.02%     
==========================================
  Files         282      282              
  Lines       16977    17024      +47     
==========================================
+ Hits        15091    15137      +46     
- Misses       1886     1887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@Enkidu93 Enkidu93 requested a review from isaac091 June 3, 2025 13:29
Copy link
Collaborator

@isaac091 isaac091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@ddaspit ddaspit force-pushed the fix-strip-paras branch from 701d191 to 3f93d92 Compare June 3, 2025 18:43
@ddaspit ddaspit merged commit a91a73b into main Jun 3, 2025
14 checks passed
@ddaspit ddaspit deleted the fix-strip-paras branch June 3, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too many paragraph markers are being stripped when using paragraph_behavior=STRIP

5 participants