Skip to content

Conversation

@ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jun 2, 2025


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (a91a73b) to head (d6bfb74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   88.91%   88.92%           
=======================================
  Files         282      282           
  Lines       17024    17035   +11     
=======================================
+ Hits        15137    15148   +11     
  Misses       1887     1887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@Enkidu93 Enkidu93 requested a review from isaac091 June 3, 2025 13:29
Copy link
Collaborator

@isaac091 isaac091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

- includes empty paragraph markers at end of verse rows when including markers
- fixes #188
@ddaspit ddaspit merged commit e631be8 into main Jun 3, 2025
14 checks passed
@ddaspit ddaspit deleted the fix-empty-para branch June 3, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Row incorrectly contains paragraph marker when an empty paragraph precedes a non-verse paragraph

5 participants