Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jun 16, 2025

Fixes #173


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit June 16, 2025 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (a6d5a1f) to head (ef65cf5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   88.92%   88.93%           
=======================================
  Files         282      282           
  Lines       17044    17056   +12     
=======================================
+ Hits        15157    15169   +12     
  Misses       1887     1887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93
Copy link
Collaborator Author

I went ahead and added a test. This code is tested elsewhere on the Serval/Machine side. Regardless, I can add the same test there if you'd prefer.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 merged commit 5579c2d into main Jun 19, 2025
14 checks passed
@Enkidu93 Enkidu93 deleted the port_remark_adding branch June 19, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to add remarks when updating usfm

4 participants