Skip to content

Conversation

@isaac091
Copy link
Collaborator

@isaac091 isaac091 commented Jun 21, 2025

Also a small change to not count headers as elements that need to be placed.


This change is Reviewable

@isaac091 isaac091 requested review from Enkidu93 and ddaspit June 21, 2025 03:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (cd21706) to head (a3290b8).

Files with missing lines Patch % Lines
...corpora/place_markers_usfm_update_block_handler.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.01%     
==========================================
  Files         282      282              
  Lines       17062    17066       +4     
==========================================
+ Hits        15175    15178       +3     
- Misses       1887     1888       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@isaac091 isaac091 merged commit 417c95f into main Jun 23, 2025
14 checks passed
@isaac091 isaac091 deleted the style_spacing branch June 23, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants