Skip to content

Use 'src' and 'trg' mirroring silnlp when src and trg lang codes are equal #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enkidu93 merged 4 commits into from
Jun 25, 2025
Merged

Use 'src' and 'trg' mirroring silnlp when src and trg lang codes are equal #199

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c431412
Use 'src' and 'trg' mirroring silnlp when src and trg lang codes are …
Enkidu93 Jun 23, 2025
ab1210b
Don't use local vars when finding missing characters
Enkidu93 Jun 23, 2025
39ca9cf
Compress if statements
Enkidu93 Jun 23, 2025
84ba0ac
Use src_lang/tgt_lang for missing characters since it operates on the…
Enkidu93 Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions machine/translation/huggingface/hugging_face_nmt_model_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ def train(
tgt_lang = self._tgt_lang
if tgt_lang is None:
tgt_lang = "tgt"
if src_lang == tgt_lang:
src_lang += "_src"
tgt_lang += "_trg"

if isinstance(self._corpus, Dataset):
train_dataset = self._corpus
Expand Down Expand Up @@ -206,13 +209,12 @@ def add_tokens(tokenizer: Any, missing_tokens: List[str]) -> Any:
use_fast=True,
)
# using unofficially supported behavior to set the normalizer
lang_codes = []
tokenizer.backend_tokenizer.normalizer = norm_tok.backend_tokenizer.normalizer # type: ignore
if self._add_unk_src_tokens and self._add_unk_tgt_tokens:
lang_codes = [src_lang, tgt_lang]
elif self._add_unk_src_tokens:
lang_codes = [src_lang]
else:
lang_codes = [tgt_lang]
if self._add_unk_src_tokens:
lang_codes.append(src_lang)
if self._add_unk_tgt_tokens:
lang_codes.append(tgt_lang)
missing_tokens = find_missing_characters(tokenizer, train_dataset, lang_codes)
if missing_tokens:
tokenizer = add_tokens(tokenizer, missing_tokens)
Expand Down