-
-
Notifications
You must be signed in to change notification settings - Fork 3
Port machine quotation analysis changes #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 333 333
Lines 21683 21697 +14
=======================================
+ Hits 19756 19769 +13
- Misses 1927 1928 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 48 of 49 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @benjaminking)
tests/corpora/punctuation_analysis/test_chapter.py line 0 at r2 (raw file):
You forgot to move all of the test files.
tests/corpora/punctuation_analysis/test_chapter.py line 1 at r2 (raw file):
import machine.corpora # pyright: ignore[reportMissingImports] # noqa: F401
Why is this import necessary?
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 36 of 50 files reviewed, 2 unresolved discussions (waiting on @benjaminking and @ddaspit)
tests/corpora/punctuation_analysis/test_chapter.py line 1 at r2 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why is this import necessary?
It isn't now that I've moved the tests 👍
tests/corpora/punctuation_analysis/test_chapter.py line at r2 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You forgot to move all of the test files.
Oops - done!
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benjaminking)
A few small changes came out of the Machine C# porting PR:
This change is