Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Aug 12, 2025

A few small changes came out of the Machine C# porting PR:

  • Move punctuation_analysis out of corpora
  • Fix remark token insertion
  • Remove unused field

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (8f18076) to head (0f257ca).

Files with missing lines Patch % Lines
machine/corpora/update_usfm_parser_handler.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         333      333           
  Lines       21683    21697   +14     
=======================================
+ Hits        19756    19769   +13     
- Misses       1927     1928    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 48 of 49 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @benjaminking)


tests/corpora/punctuation_analysis/test_chapter.py line 0 at r2 (raw file):
You forgot to move all of the test files.


tests/corpora/punctuation_analysis/test_chapter.py line 1 at r2 (raw file):

import machine.corpora  # pyright: ignore[reportMissingImports] # noqa: F401

Why is this import necessary?

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 36 of 50 files reviewed, 2 unresolved discussions (waiting on @benjaminking and @ddaspit)


tests/corpora/punctuation_analysis/test_chapter.py line 1 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Why is this import necessary?

It isn't now that I've moved the tests 👍


tests/corpora/punctuation_analysis/test_chapter.py line at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You forgot to move all of the test files.

Oops - done!

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @benjaminking)

@Enkidu93 Enkidu93 merged commit 23448db into main Aug 14, 2025
14 checks passed
@Enkidu93 Enkidu93 deleted the port_machine_quotation_analysis_changes branch August 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants