Dockerfile updates #216
Merged
Dockerfile updates #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaspit
approved these changes
Aug 18, 2025
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
I like that we are more explicit with the Debian version now. It is also really nice that you were able to use the slim image.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Enkidu93
force-pushed
the
dockerfile_updates
branch
from
c68b561 to
14f9f51
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 333 333
Lines 21697 21697
=======================================
Hits 19769 19769
Misses 1928 1928 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that I 'reverted' to bookworm. We should consider updating to trixie, but it's probably better to be more explicit anyways and intentionally make that change - not have it quietly forced upon us. I also switched to the slim image. All we needed that wasn't in slim were things to build eflomal (make, gcc, ...) which cut down the image size a few hundred megabytes. Also, I removed the links because they weren't really doing anything.
This change is