Fix type for Russian versifications #217
Conversation
ddaspit
force-pushed
the
rus-vers-types
branch
from
1dfdd34 to
b45eac3
Compare
|
This is a fix for an issue in silnlp. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 333 333
Lines 21697 21706 +9
=======================================
+ Hits 19769 19778 +9
Misses 1928 1928 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
Enkidu93
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
benjaminking
left a comment
benjaminking
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
ddaspit
force-pushed
the
rus-vers-types
branch
from
b45eac3 to
e21994f
Compare
| def test_builtin_versification_type() -> None: | ||
| assert ENGLISH_VERSIFICATION.type == VersificationType.ENGLISH | ||
| assert ORIGINAL_VERSIFICATION.type == VersificationType.ORIGINAL | ||
| assert RUSSIAN_ORTHODOX_VERSIFICATION.type == VersificationType.RUSSIAN_ORTHODOX |
There was a problem hiding this comment.
@ddaspit Since there are only 6 types, why not just have an assertion for each of them?
ddaspit
force-pushed
the
rus-vers-types
branch
from
e21994f to
f3e68ed
Compare
ddaspit
force-pushed
the
rus-vers-types
branch
from
f3e68ed to
ed5e55c
Compare
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @benjaminking, @Enkidu93, and @jcuenod)
| def test_builtin_versification_type() -> None: | ||
| assert ENGLISH_VERSIFICATION.type == VersificationType.ENGLISH | ||
| assert ORIGINAL_VERSIFICATION.type == VersificationType.ORIGINAL | ||
| assert RUSSIAN_ORTHODOX_VERSIFICATION.type == VersificationType.RUSSIAN_ORTHODOX |
This change is