Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Sep 4, 2025

Fixes #201


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (60417c4) to head (cbdcb62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   91.11%   91.12%           
=======================================
  Files         333      333           
  Lines       21706    21728   +22     
=======================================
+ Hits        19778    19800   +22     
  Misses       1928     1928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)


machine/translation/huggingface/hugging_face_nmt_engine.py line 166 at r1 (raw file):

                for token, score in zip(output["translation_tokens"], output["token_scores"]):
                    builder.append_token(token, TranslationSources.NMT, exp(score))
                word_pairs = None

Please specify the type for this variable.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the config_output_attentions branch from 623b0d9 to 950e67c Compare September 7, 2025 23:24
Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)


machine/translation/huggingface/hugging_face_nmt_engine.py line 166 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Please specify the type for this variable.

Done.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the config_output_attentions branch from 950e67c to cbdcb62 Compare September 8, 2025 19:05
@pmachapman pmachapman merged commit ef180a3 into main Sep 8, 2025
14 checks passed
@pmachapman pmachapman deleted the config_output_attentions branch September 8, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HuggingFaceNmtEngine does not use SDPA attention implementation

5 participants