-
-
Notifications
You must be signed in to change notification settings - Fork 3
Allow output_attentions to be set to False #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 91.11% 91.12%
=======================================
Files 333 333
Lines 21706 21728 +22
=======================================
+ Hits 19778 19800 +22
Misses 1928 1928 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
machine/translation/huggingface/hugging_face_nmt_engine.py line 166 at r1 (raw file):
for token, score in zip(output["translation_tokens"], output["token_scores"]): builder.append_token(token, TranslationSources.NMT, exp(score)) word_pairs = None
Please specify the type for this variable.
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Enkidu93 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
623b0d9 to
950e67c
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
machine/translation/huggingface/hugging_face_nmt_engine.py line 166 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Please specify the type for this variable.
Done.
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
950e67c to
cbdcb62
Compare
Fixes #201
This change is