Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented May 5, 2025

Partially addresses sillsdev/serval#542

This needs to be merged and a new version of Machine needs to be released before the Serval PR can be merged.


This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)


src/SIL.Machine/Corpora/ParatextProjectTextUpdaterBase.cs line 31 at r1 (raw file):

            UpdateUsfmMarkerBehavior styleBehavior = UpdateUsfmMarkerBehavior.Strip,
            IReadOnlyCollection<string> preserveParagraphStyles = null,
            IReadOnlyList<string> remarks = null

This can be an IEnumerable.

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)


src/SIL.Machine/Corpora/ParatextProjectTextUpdaterBase.cs line 31 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

This can be an IEnumerable.

Done.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.50%. Comparing base (58098ed) to head (3d1ca71).

Files with missing lines Patch % Lines
src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs 40.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   70.52%   70.50%   -0.02%     
==========================================
  Files         386      386              
  Lines       32299    32311      +12     
  Branches     4543     4546       +3     
==========================================
+ Hits        22779    22782       +3     
- Misses       8472     8479       +7     
- Partials     1048     1050       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 merged commit d202171 into master May 7, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the add_ability_to_add_remarks branch May 7, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants