-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add ability to add remarks #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
src/SIL.Machine/Corpora/ParatextProjectTextUpdaterBase.cs line 31 at r1 (raw file):
UpdateUsfmMarkerBehavior styleBehavior = UpdateUsfmMarkerBehavior.Strip, IReadOnlyCollection<string> preserveParagraphStyles = null, IReadOnlyList<string> remarks = null
This can be an IEnumerable.
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/SIL.Machine/Corpora/ParatextProjectTextUpdaterBase.cs line 31 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This can be an
IEnumerable.
Done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 70.52% 70.50% -0.02%
==========================================
Files 386 386
Lines 32299 32311 +12
Branches 4543 4546 +3
==========================================
+ Hits 22779 22782 +3
- Misses 8472 8479 +7
- Partials 1048 1050 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Partially addresses sillsdev/serval#542
This needs to be merged and a new version of Machine needs to be released before the Serval PR can be merged.
This change is