Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Sep 29, 2025

Fixes sillsdev/serval#756


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit September 29, 2025 17:31
@Enkidu93
Copy link
Collaborator Author

This will need to be ported to machine.py.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the align_terms_processing_with_silnlp branch from e952a36 to f88004a Compare September 29, 2025 20:10
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.29%. Comparing base (1bcb5fd) to head (b5a6bdf).

Files with missing lines Patch % Lines
....Machine/Corpora/ParatextProjectTermsParserBase.cs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   72.28%   72.29%           
=======================================
  Files         417      417           
  Lines       35467    35475    +8     
  Branches     4900     4900           
=======================================
+ Hits        25638    25646    +8     
  Misses       8731     8731           
  Partials     1098     1098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 merged commit 1662968 into master Sep 29, 2025
3 of 4 checks passed
@Enkidu93 Enkidu93 deleted the align_terms_processing_with_silnlp branch September 29, 2025 20:55
Enkidu93 added a commit to sillsdev/machine.py that referenced this pull request Oct 2, 2025
Enkidu93 added a commit to sillsdev/machine.py that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Key terms - silnlp/Serval consistency in extracting key terms renderings

4 participants