Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Sep 30, 2025

Porting sillsdev/machine.py#234 and sillsdev/machine.py#235.

Related to sillsdev/serval#773.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.33%. Comparing base (ba5915c) to head (db40607).

Files with missing lines Patch % Lines
...uationAnalysis/PreliminaryQuotationMarkAnalyzer.cs 93.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   72.32%   72.33%           
=======================================
  Files         418      418           
  Lines       35579    35599   +20     
  Branches     4914     4919    +5     
=======================================
+ Hits        25732    25750   +18     
- Misses       8751     8752    +1     
- Partials     1096     1097    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 force-pushed the port_quotation_denormalization_updates branch from e3ce80e to 82013e4 Compare September 30, 2025 20:06
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the port_quotation_denormalization_updates branch from 82013e4 to db40607 Compare October 1, 2025 21:25
@Enkidu93 Enkidu93 merged commit 15919fb into master Oct 1, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the port_quotation_denormalization_updates branch October 1, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants