Don't use ToDictionary if includeChapters is null

[Enkidu93]

This change is 

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.38%. Comparing base (0118bad) to head (f59af54).

Files with missing lines	Patch %	Lines
...Analysis/ParatextProjectQuoteConventionDetector.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files         417      417           
  Lines       35632    35632           
  Branches     4928     4929    +1     
=======================================
  Hits        25793    25793           
  Misses       8744     8744           
  Partials     1095     1095           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ddaspit]

@ddaspit reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 38 at r1 (raw file):

            return GetQuoteConventionAnalysis(
                handler,
                includeChapters.ToDictionary(kvp => Canon.BookIdToNumber(kvp.Key), kvp => kvp.Value) ?? null

Unless I'm missing something, I don't think this will work. ToDictionary will still throw an exception if includeChapters is null. You need something more like:

includeChapters?.ToDictionary(kvp => Canon.BookIdToNumber(kvp.Key), kvp => kvp.Value)

[Enkidu93]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

---

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 38 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Unless I'm missing something, I don't think this will work. ToDictionary will still throw an exception if includeChapters is null. You need something more like:

includeChapters?.ToDictionary(kvp => Canon.BookIdToNumber(kvp.Key), kvp => kvp.Value)

You aren't missing anything 😆. Just me committing code at the end of a very long day haha. Fixed. Sorry about that. That made less than no sense.

[ddaspit]

@ddaspit reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)