reference SIL packages in packages.config#58
Conversation
…n the libs folder.
|
see: https://sil-language-software.slack.com/archives/C87FMEEE6/p1715972226593669 If I understand correctly, this PR removes the old "download dependencies from TC" piece and replaces them with nuget references. If so, how about we delete the scripts so as not to confuse future devs? |
|
those scripts say they're auto generated, is there a workflow that creates them or does someone run those manually when they know to? |
My feeling is that if you didn't need to run those scripts because you successfully built Pathway by adding the appropriate nuget dependencies. I guess Greg could say for sure. I think it's worth putting in the PR to try and get rid of them since you are going 100% nuget. Here's the history as I understand it (I could be wrong about some of this):
|
|
alright that makes sense. I've removed those scripts. |

This builds off of commit ca5733f before master reverted back to dotnet 4.6.2, not sure where it would be best to merge back into. This mostly works by referencing the latest version of SIL packages as I didn't have the correct version on my machine, this should also make for a more consistent setup process for devs as they don't have to go find and download the dlls as nuget does that for them.
I left a couple todo comments in places where I'm not sure what the best course of action would be.