Skip to content

reference SIL packages in packages.config#58

Open
hahn-kev wants to merge 2 commits into
sillsdev:developfrom
hahn-kev:user-nuget-for-sil-libs
Open

reference SIL packages in packages.config#58
hahn-kev wants to merge 2 commits into
sillsdev:developfrom
hahn-kev:user-nuget-for-sil-libs

Conversation

@hahn-kev
Copy link
Copy Markdown

This builds off of commit ca5733f before master reverted back to dotnet 4.6.2, not sure where it would be best to merge back into. This mostly works by referencing the latest version of SIL packages as I didn't have the correct version on my machine, this should also make for a more consistent setup process for devs as they don't have to go find and download the dlls as nuget does that for them.

I left a couple todo comments in places where I'm not sure what the best course of action would be.

@megahirt
Copy link
Copy Markdown

see: https://sil-language-software.slack.com/archives/C87FMEEE6/p1715972226593669

If I understand correctly, this PR removes the old "download dependencies from TC" piece and replaces them with nuget references. If so, how about we delete the scripts so as not to confuse future devs?
image

@hahn-kev
Copy link
Copy Markdown
Author

those scripts say they're auto generated, is there a workflow that creates them or does someone run those manually when they know to?

@megahirt
Copy link
Copy Markdown

those scripts say they're auto generated, is there a workflow that creates them or does someone run those manually when they know to?

My feeling is that if you didn't need to run those scripts because you successfully built Pathway by adding the appropriate nuget dependencies. I guess Greg could say for sure. I think it's worth putting in the PR to try and get rid of them since you are going 100% nuget.

Here's the history as I understand it (I could be wrong about some of this):

  • For projects that have been around a long time and haven't been updated to use nuget, the getDependencies.sh scripts wereare still used to download dependencies from TC.
  • SIL shared libraries like libpalaso used to not be published on nuget. The only way was to download builds from teamcity or build them yourself.
  • The project's dependency graph was encoded in the TeamCity UI itself. The pathway project probably had a dependency on a specific version (or even a specific branch!) of libpalaso, and that was specified in a TC Pathway build config.
  • Chris Hubbard made a ruby script that fetched the TC build config and then autogenerated a getDependency.sh script to make it easy for developers to downloaded the needed dependencies for their project. As long as the dependency build targets didn't change, you didn't need to rerun the ruby script. He basically implemented nuget, haha :)
  • Before this, the only way was to build the dependencies yourself or download them one at a time from the TC UI I think.

@hahn-kev
Copy link
Copy Markdown
Author

alright that makes sense. I've removed those scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants