Skip to content

improve JSON.stringify#17

Merged
irahopkinson merged 1 commit into
mainfrom
to-json
Jun 26, 2024
Merged

improve JSON.stringify#17
irahopkinson merged 1 commit into
mainfrom
to-json

Conversation

@irahopkinson
Copy link
Copy Markdown
Collaborator

@irahopkinson irahopkinson commented Jun 20, 2024 •
edited
Loading

  • BREAKING CHANGE - previously it just serialized the properties (no getters).
  • BREAKING CHANGE - remove deprecated parse method
  • bump to v2.0.0
  • also update dependencies.
  • also bump deprecated actions

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (3bc5fbd) to head (92e2c91).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   84.70%   86.22%   +1.52%     
==========================================
  Files           4        4              
  Lines         353      363      +10     
  Branches      105      110       +5     
==========================================
+ Hits          299      313      +14     
+ Misses         52       50       -2     
+ Partials        2        0       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irahopkinson irahopkinson force-pushed the to-json branch 7 times, most recently from 4251f4e to e9ef262 Compare June 20, 2024 21:42
@irahopkinson
improve JSON.stringify
92e2c91 
- BREAKING CHANGE - previously it just serialized the properties (no getters).
- BREAKING CHANGE - remove deprecated `parse` method
- bump to v2.0.0
- also update dependencies
- also bump deprecated actions
@irahopkinson irahopkinson marked this pull request as ready for review June 20, 2024 21:54
@irahopkinson irahopkinson enabled auto-merge (squash) June 20, 2024 21:55
@irahopkinson irahopkinson disabled auto-merge June 20, 2024 22:06
tjcouch-sil
tjcouch-sil approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the context behind why you are making this change, but it seems fine.

I do wonder, though, why choose to serialize with book instead of bookNum? Seems bookNum would give more consistency with the other fields. Doesn't really matter much, though, so I'm approving. I imagine you had a good reason anyway.

I don't have any changes in mind for v1.

Note: I think you may have to tune up VerseRefConverter in P.B to support this.

lyonsil
lyonsil approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@irahopkinson
Copy link
Copy Markdown
Collaborator Author

irahopkinson commented Jun 21, 2024

@tjcouch-sil Using book makes the serialized output more human readable than bookNum, e.g. it's really hard to know what bookNum=19 is but book="PSA" is more obvious.

@irahopkinson irahopkinson merged commit 209054a into main Jun 26, 2024
@irahopkinson irahopkinson deleted the to-json branch June 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tjcouch-sil tjcouch-sil tjcouch-sil approved these changes

@lyonsil lyonsil lyonsil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irahopkinson @tjcouch-sil @lyonsil