DOC Update PHPUnit code sample #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GuySartorelli
requested changes
Sep 17, 2024
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
Please add an example of how to use enableErrorHandler() to the unit and integration testing page (or elsewhere if you find somewhere more appropriate).
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
7fd42fb to
f883b2c
Compare
Member
Author
|
Done - during this I also noticed that I didn't have any unit tests for SapphireTest::enableErrorHandler, so I've added those Also I made some changes to the code as well to simply fallback to the standard php error handler if the errno wasn't one of the 6 that we're catching. This means that deprecation notices will still display properly instead of being thrown as Exceptions. |
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
f883b2c to
264ab0a
Compare
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
264ab0a to
c26b2a7
Compare
GuySartorelli
approved these changes
Sep 18, 2024
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
LGTM will merge when all other PRs are approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#305