DOC Document deprecations for template layer refactor #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Linting failure is unrelated |
Closed
23 tasks
emteknetnz
requested changes
Oct 16, 2024
Member
emteknetnz
left a comment
emteknetnz
left a comment
There was a problem hiding this comment.
Missing SSViewer::execute_template() + SSViewer::execute_string()
GuySartorelli
force-pushed
the
pulls/5/template-deprecations
branch
from
b0bdc53 to
b430ed9
Compare
Member
|
Still need to add SSViewer::execute_template() + SSViewer::execute_string(), and rebase |
GuySartorelli
force-pushed
the
pulls/5/template-deprecations
branch
from
b430ed9 to
adf2849
Compare
Member
Author
|
Oops! Sorry, I was so focused on updating the code PRs I forgot this had a requested change. |
emteknetnz
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue