-
Notifications
You must be signed in to change notification settings - Fork 73
DOC Validate DBFields #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Validate DBFields #596
Conversation
d72bcca to
57e18c0
Compare
0e8d5ae to
7ec82e3
Compare
92d0103 to
1113a3c
Compare
4892222 to
cf84092
Compare
cf84092 to
b63935d
Compare
b63935d to
e27608a
Compare
e27608a to
5be92d0
Compare
|
Please address all of the outstanding comments before reassigning this to me again. |
a5e3c90 to
abb1bd0
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't realise you'd changed the config names to the class names in that table.
a2aa185 to
642f788
Compare
642f788 to
112e646
Compare
112e646 to
f93ffa8
Compare
f93ffa8 to
13b6f0f
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/silverstripe-framework#11403