Skip to content

Conversation

@emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 3 times, most recently from d72bcca to 57e18c0 Compare October 11, 2024 01:37
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 2 times, most recently from 0e8d5ae to 7ec82e3 Compare October 14, 2024 21:49
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 2 times, most recently from 92d0103 to 1113a3c Compare October 21, 2024 05:28
@emteknetnz emteknetnz marked this pull request as ready for review October 21, 2024 21:33
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 2 times, most recently from 4892222 to cf84092 Compare October 25, 2024 02:52
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from cf84092 to b63935d Compare October 31, 2024 02:33
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from b63935d to e27608a Compare November 4, 2024 23:17
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from e27608a to 5be92d0 Compare November 5, 2024 21:24
@GuySartorelli
Copy link
Member

Please address all of the outstanding comments before reassigning this to me again.

@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 3 times, most recently from a5e3c90 to abb1bd0 Compare November 6, 2024 23:14
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't realise you'd changed the config names to the class names in that table.

@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch 2 times, most recently from a2aa185 to 642f788 Compare November 7, 2024 00:36
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from 642f788 to 112e646 Compare November 7, 2024 01:23
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from 112e646 to f93ffa8 Compare November 7, 2024 01:59
@emteknetnz emteknetnz force-pushed the pulls/6/field-validators branch from f93ffa8 to 13b6f0f Compare November 7, 2024 03:02
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ede5aa4 into silverstripe:6 Nov 7, 2024
@GuySartorelli GuySartorelli deleted the pulls/6/field-validators branch November 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants