Skip to content

Conversation

@maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Oct 19, 2024

Description

Add entry about utf8mb4 encoding update to changelog

Issues

Related PRs

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@maxime-rainville
Copy link
Contributor Author

The linting is failing ... but because of the 5.3rc changelog.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@GuySartorelli GuySartorelli merged commit a0e3f11 into silverstripe:6 Oct 21, 2024
@maxime-rainville maxime-rainville deleted the pulls/6/utf8mb4 branch October 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants