Skip to content

Conversation

@lerni
Copy link
Contributor

@lerni lerni commented Nov 19, 2024

Description

Update JS MIME type, remove type in <script> silverstripe/silverstripe-framework#11446, fix few typos

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@lerni lerni changed the title Change JS MIME Type & Remove Default type in <script> silverstripe/silverstripe-framework/pull/11446, fix few typos Change JS MIME type & remove default type in <script> silverstripe/silverstripe-framework/pull/11446, fix few typos Nov 19, 2024
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Some suggested changes to wording below.

@GuySartorelli GuySartorelli self-assigned this Nov 19, 2024
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have asked for this last time, but can you please also prefix the commit message with DOC as per https://docs.silverstripe.org/en/5/contributing/code/#commit-messages

@lerni lerni changed the title Change JS MIME type & remove default type in <script> silverstripe/silverstripe-framework/pull/11446, fix few typos DOC Update JS MIME type, remove type in <script> silverstripe/silverstripe-framework/pull/11446, fix few typos Nov 19, 2024
@lerni lerni changed the title DOC Update JS MIME type, remove type in <script> silverstripe/silverstripe-framework/pull/11446, fix few typos DOC Update JS MIME type, remove type in <script>, fix few typos Nov 19, 2024
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@GuySartorelli GuySartorelli merged commit ac404a3 into silverstripe:6 Nov 20, 2024
3 checks passed
@lerni lerni deleted the change-js-mime-type branch November 21, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants