DOC Document changes to cookie API and some default changes #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
GuySartorelli
commented
Mar 11, 2025
Comment on lines
-849
to
-860
| We also want to ensure cookies are not shared between secure and non-secure sessions, so we must tell Silverstripe CMS to | ||
| use a [secure session](/developer_guides/cookies_and_sessions/sessions/#secure-session-cookie). | ||
| To do this, you may set the `cookie_secure` parameter to `true` in your `config.yml` for `Session`. | ||
|
|
||
| It is also a good idea to set the `samesite` attribute for the session cookie to `Strict` unless you have a specific use case for | ||
| sharing the session cookie across domains. | ||
|
|
||
| ```yml | ||
| SilverStripe\Control\Session: | ||
| cookie_samesite: 'Strict' | ||
| cookie_secure: true | ||
| ``` |
Member
Author
There was a problem hiding this comment.
This part should have been updated as part of #712.
I've opted to remove it, and instead just make sure this section links to the sessions docs, which includes this information.
emteknetnz
requested changes
Mar 12, 2025
|
|
||
| Clears a given cookie. | ||
|
|
||
| The same values used for `$path`, `$domain`, `$secure`, `$httpOnly`, and `$sameSite` when seting the cookie should be used here as well. |
Member
There was a problem hiding this comment.
Suggested change
| The same values used for `$path`, `$domain`, `$secure`, `$httpOnly`, and `$sameSite` when seting the cookie should be used here as well. | |
| The same values used for `$path`, `$domain`, `$secure`, `$httpOnly`, and `$sameSite` when setting the cookie should be used here as well. |
GuySartorelli
force-pushed
the
pulls/6.0/cookie-samesite
branch
from
d6985ee to
ce96f6c
Compare
GuySartorelli
force-pushed
the
pulls/6.0/cookie-samesite
branch
from
ce96f6c to
19f9713
Compare
emteknetnz
approved these changes
Mar 13, 2025
GuySartorelli
added a commit
to creative-commoners/developer-docs
that referenced
this pull request
Mar 14, 2025
GuySartorelli
added a commit
to creative-commoners/developer-docs
that referenced
this pull request
Mar 14, 2025
GuySartorelli
added a commit
to creative-commoners/developer-docs
that referenced
this pull request
Mar 14, 2025
GuySartorelli
added a commit
to creative-commoners/developer-docs
that referenced
this pull request
Mar 14, 2025
GuySartorelli
added a commit
to creative-commoners/developer-docs
that referenced
this pull request
Mar 14, 2025
emteknetnz
pushed a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue