DOC Document filesystem performance improvements #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
GuySartorelli
force-pushed
the
pulls/6/filesystem-performance
branch
from
1095184 to
39f9cbd
Compare
GuySartorelli
commented
May 12, 2025
|
|
||
| | Field name | Description | | ||
| | ---------- | ----------- | ||
| | ---------- | ----------- | |
Member
Author
There was a problem hiding this comment.
Unrelated fix to table syntax. It's rendering fine without this for now but other markdown parsers could be more strict if we change our doc renderer in the future.
GuySartorelli
force-pushed
the
pulls/6/filesystem-performance
branch
from
39f9cbd to
e7ccff0
Compare
emteknetnz
requested changes
May 19, 2025
Member
emteknetnz
left a comment
emteknetnz
left a comment
There was a problem hiding this comment.
I'm part way reviewing this, will submit for now. Depending on what we do on the main PR may change this PR quite a bit
| - Reduced the number of times we check if a folder is empty by removing duplicate checks. | ||
| - Added [`Filesystem::isEmpty()`](api:SilverStripe\Assets\Flysystem\Filesystem::isEmpty()) to check if a folder is empty. With the default local filesystem adapter, this means we check exactly one file to know if the folder is empty or not. With other adapters it depends on the implementation (e.g. the AWS S3 adapter will likely still fetch a full page of up to 1000 files). | ||
| - Added [`GlobContentLister`](api:SilverStripe\Assets\Flysystem\GlobContentLister) and [`GlobbableFileIDHelper`](api:SilverStripe\Assets\FilenameParsing\GlobbableFileIDHelper) interfaces to enable looking for image variants using a glob pattern. This dramatically improves performance with the default local filesystem adapter, but by default will have no effect for other adapters. | ||
| If you are using a different adapter that might support globbing such as using FTP (for specific FTP servers), consider implementing the `GlobContentLister` interface. |
Member
There was a problem hiding this comment.
Using FTP as a filesystem? For a Silverstripe install? That seems very strange, is there a different example you could give that's a little more standard?
Member
Author
There was a problem hiding this comment.
The official adapters are:
- Local
- FTP
- InMemory
- Read-Only
- Path Prefixing
- AWS S3
- AsyncAws S3
- Azure Blob Storage
- Google Cloud Storage
- MongoDB GridFS
- SFTP (V2)
- SFTP (V3)
- WebDAV
- ZipArchive
If another of those stands out as a better example which can support glob pattern matching I'll be happy to swap it out. I think SFTP can handle glob pattern matching.
GuySartorelli
force-pushed
the
pulls/6/filesystem-performance
branch
from
e7ccff0 to
82c962f
Compare
emteknetnz
approved these changes
May 22, 2025
emteknetnz
pushed a commit
to creative-commoners/developer-docs
that referenced
this pull request
Jul 22, 2025
lozcalver
pushed a commit
to lozcalver/developer-docs
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue