Skip to content

Conversation

@emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 17, 2025

@GuySartorelli
Copy link
Member

Should target 5.4 or 6.0 so it doesn't have to wait til the next beta to be visible.

@emteknetnz emteknetnz force-pushed the pulls/6/module-docs branch from 1558e1f to 628f194 Compare July 21, 2025 05:44
@emteknetnz emteknetnz force-pushed the pulls/6/module-docs branch from 628f194 to c0dbbd0 Compare July 22, 2025 03:51
@emteknetnz emteknetnz changed the base branch from 6 to 6.0 July 22, 2025 03:54
@emteknetnz
Copy link
Member Author

Re-targeted to 6.0

@emteknetnz emteknetnz force-pushed the pulls/6/module-docs branch from c0dbbd0 to 6a515aa Compare July 22, 2025 03:55
@emteknetnz
Copy link
Member Author

@GuySartorelli Any idea how to fix this linting issue https://github.com/silverstripe/developer-docs/actions/runs/16434204908/job/46441140300?pr=780#step:8:40

It's complaining that all the existing silverstripe/realme is not capitilised properly as RealMe post merging silverstripe/documentation-lint#25

@emteknetnz
Copy link
Member Author

Oh right - noticed you mentioned here silverstripe/documentation-lint#25 (comment)

@GuySartorelli
Copy link
Member

You've pulled a bunch of commits from 6 with you when you retargetted the PR. Please reset your commits so that you only have the relevant commits.

@emteknetnz emteknetnz force-pushed the pulls/6/module-docs branch from 6a515aa to d111e67 Compare July 23, 2025 03:52
@emteknetnz
Copy link
Member Author

Done

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 6a69b6f into silverstripe:6.0 Jul 23, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/module-docs branch July 23, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants